-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning if config is marked as untested #114
Comments
Thank you for the suggestion :) |
If it works not the same every time or if someone makes a config without having the device itself, so others can test and verify it... (Just like I recently offered someone on fedi to write a config for their device) |
Also the configs are already declared as |
Yeah, I will soon try to align information in the README and in the configs (and on the website). Then the configs will be the only source of truth on what and how stuff is supported. Maybe even more details, it also came up here: #116 |
Could also be done with #221 |
Not quite, but mayve 🤔 |
I don't think it's really useful, since you just have to put this in
Instead of
I think |
I think that it is better to convert as much as possible into fileds / variables, to ensure continuety and avoid spelling issues, as I occasionally find spelling issues in every config now and then... I mean another field is not neccesary, but would just look nice. Also all the warnings and notes you wrote for the Xiaomi devices could be hard coded and just set by `is_xiaomi: true. (Or something like that.) It also makes the configs more simple and not that crammed. |
resolved with #221 |
For experimental or untested configs it would be nice to have a config metadata to mark it as experimental/untested and output a warning in OAI.
The text was updated successfully, but these errors were encountered: