Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to Connect without Resetting #95

Open
4 tasks
baffo32 opened this issue Oct 16, 2016 · 1 comment
Open
4 tasks

Allow to Connect without Resetting #95

baffo32 opened this issue Oct 16, 2016 · 1 comment

Comments

@baffo32
Copy link
Contributor

baffo32 commented Oct 16, 2016

It would be nice to connect to the device without having to reset it, for command-line utilities that just perform one function, and to maintain a long-term SD log without interruption.

I began this in #82, but it turns out a lot of subtle issues with the library obstruct testing. I will likely withdraw #82 and submit a new pull request that is rebased on a more recent commit, while adding the dependent issues to the issue tracker.

  • Address all dependent issues (at least Socket not closed if connect() called twice #93 and State not cleaned up on socket close #92)
  • Optionally separate the simulator from the connect/disconnect cycle, so it has its own lifetime
  • Provide an option flag determining whether the connection owns or manages the lifetime of the board, defaulting to false. If set to true, the board will be reset when connected, and streaming will be halted when disconnected.
  • Test for all combinations of this flag with the connect / disconnect functions, and any other relevant combinations introduced.
@andrewjaykeller
Copy link

@baffo32 please rebase off master and continue developing!

Please checkout the latest release: https://github.com/OpenBCI/OpenBCI_NodeJS/releases/tag/v1.3.3

Ignore 1.4.0 semi-standard adoption until we figure out the best was to handle it. I think this issue should be addressed and closed so we can do #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants