-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GanglionDelegate::parse_raw() - Line 159: struct not defined, packet not defined #10
Comments
The issue is currently here: The problem is twofold. First struct isn't imported, which isn't a big problem to fix, just add So that means that if we want to replicate the functionality of the old code the I can make a PR to do this if desired. |
Thanks Ian. I don't know what a PR is, sorry. Maybe you can give me some advises to read some board settings using this library. Thanks in advice. |
I made the pull request to fix these issues, you can see it above. Please let me know if this patch fixes this issue, as I don't have a Ganglion to test with. You may run into other issues, I think I see some problems in the code that may stop you, but we'll at least fix this issue for now. |
OK. I will test by the end of the week. |
Dear Ian, I have wrapped pyOpenBCI in a module for the Ganglion board It would be fantastic if you could expose in pyOpenBCI, or show me examples for exposing the other Ganglion SDK commands (https://docs.openbci.com/docs/03Ganglion/GanglionSDK), above all, the query register settings command "?". Thanks so much so far. |
Glad to hear the changes work for you. For your other improvements I would make issues for them describing the changed functionality here on GitHub and then propose them for inclusion in a pull request that closes your issue. |
Dears,
in the file ganglion.py, at line ~159, in GanglionDelegate::parse_raw(), the variable "struct" is not defined, as well as the variable "packet". Probably a copy-paste from Cyton board code.
Kind Regards
Matteo
The text was updated successfully, but these errors were encountered: