From 5dfece0c298876ca95ef309a620fed8d8cfa8690 Mon Sep 17 00:00:00 2001 From: Arnei Date: Wed, 26 Jun 2024 15:17:35 +0200 Subject: [PATCH 01/27] Don't word wrap on table headers We're currently applying arbitrary word-wrapping to our table cells to keep very long strings from overflowing. This can cause some columns to get very little width in certain cases. This removes word-wrapping from table headers to rectify that issue. Table header contents are controlled by us and should not be terribly long either way, so in my opinion this is fine. --- src/styles/main.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/src/styles/main.scss b/src/styles/main.scss index 728d63d86c..72ae7121f5 100644 --- a/src/styles/main.scss +++ b/src/styles/main.scss @@ -559,7 +559,6 @@ table.main-tbl { display: none !important; } - th, td { max-width: 800px; word-wrap: anywhere; From 1846c4914be3312266b8cb96736c8864431d9ebe Mon Sep 17 00:00:00 2001 From: Arnei Date: Wed, 26 Jun 2024 16:01:34 +0200 Subject: [PATCH 02/27] Prevent icon in table header from line breaking Applies flexbox to table headers to keep table header contents from line breaking. This is supposed to help with cases where the title would be on one line and the sort icon on the next, wasting space and looking quite bad. --- src/styles/main.scss | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/styles/main.scss b/src/styles/main.scss index 72ae7121f5..caceeeb3d2 100644 --- a/src/styles/main.scss +++ b/src/styles/main.scss @@ -559,6 +559,14 @@ table.main-tbl { display: none !important; } + th { + span { + display: flex; + flex-direction: row; + justify-content: space-between; + } + } + td { max-width: 800px; word-wrap: anywhere; From f4e5e1010a11d6901deddac857fdf17bf52b339e Mon Sep 17 00:00:00 2001 From: Arnei Date: Wed, 26 Jun 2024 16:52:20 +0200 Subject: [PATCH 03/27] Add missing translation key Translation key for the button to studio was missing. --- src/i18n/org/opencastproject/adminui/languages/lang-en_US.json | 1 + 1 file changed, 1 insertion(+) diff --git a/src/i18n/org/opencastproject/adminui/languages/lang-en_US.json b/src/i18n/org/opencastproject/adminui/languages/lang-en_US.json index 488dcdb2ec..7d3cb187c7 100644 --- a/src/i18n/org/opencastproject/adminui/languages/lang-en_US.json +++ b/src/i18n/org/opencastproject/adminui/languages/lang-en_US.json @@ -138,6 +138,7 @@ } }, "MEDIAMODULE": "Media Module", + "STUDIO": "Studio", "SYSTEM_NOTIFICATIONS": "System warnings and notifications", "LANGUAGE": "Select language", "HELP": { From 1697317dab755eadadde8febcb65e21208afae5f Mon Sep 17 00:00:00 2001 From: Julian Kniephoff Date: Wed, 26 Jun 2024 17:30:03 +0200 Subject: [PATCH 04/27] Remove some dead code --- src/components/shared/DropDown.tsx | 13 ------------- src/slices/eventDetailsSlice.ts | 14 -------------- 2 files changed, 27 deletions(-) diff --git a/src/components/shared/DropDown.tsx b/src/components/shared/DropDown.tsx index 12982eaefe..7644530d63 100644 --- a/src/components/shared/DropDown.tsx +++ b/src/components/shared/DropDown.tsx @@ -19,19 +19,6 @@ import Select from "react-select"; */ export type DropDownType = "language" | "isPartOf" | "license" | "captureAgent" | "aclRole" | "workflow" | "aclTemplate" | "newTheme" | "comment" | "theme" | "time"; -// type DPTime = { -// index: number, -// value: string, -// } -// type DPCaptureAgent = any; -// type DPComment = string[]; -// type DPWorkflow = Workflow[]; -// type DPAclTemplate = never[]; -// type DPAclRole = any; -// type DPNewTheme = Theme[]; -// type DPTheme = any; - - /** * This component provides a bar chart for visualising (statistics) data */ diff --git a/src/slices/eventDetailsSlice.ts b/src/slices/eventDetailsSlice.ts index bdde6074a4..24e6c2b6bd 100644 --- a/src/slices/eventDetailsSlice.ts +++ b/src/slices/eventDetailsSlice.ts @@ -2214,20 +2214,6 @@ const eventDetailsSlice = createSlice({ // This is the empty workflow data from the original reducer // TODO: Figure out why it is so vastly different from our initial state // and maybe fix our initial state if this is actually correct - // const emptyWorkflowData = { - // creator: { - // name: "", - // email: "", - // }, - // title: "", - // description: "", - // submittedAt: "", - // state: "", - // executionTime: "", - // wiid: "", - // wdid: "", - // configuration: {}, - // }; const emptyWorkflowData = { workflowId: "", description: "", From 06804869de901bad53d89e2e5fd0c6abf892c3e6 Mon Sep 17 00:00:00 2001 From: Lars Kiesow Date: Thu, 27 Jun 2024 20:56:24 +0200 Subject: [PATCH 05/27] Main menu tooltip position This patch adjusts the placement of the main menu tooltip to appear only atop the icon and be placed to the right like with all other main menu tooltips. --- src/components/shared/MainNav.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/shared/MainNav.tsx b/src/components/shared/MainNav.tsx index 53ef96a5cf..2ed243d1de 100644 --- a/src/components/shared/MainNav.tsx +++ b/src/components/shared/MainNav.tsx @@ -234,11 +234,11 @@ const MainNav = ({ return ( <>
- - - + + {isOpen && (