Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify onie img file #957

Open
ingridcelestica opened this issue Oct 10, 2023 · 5 comments
Open

Specify onie img file #957

ingridcelestica opened this issue Oct 10, 2023 · 5 comments

Comments

@ingridcelestica
Copy link
Contributor

ingridcelestica commented Oct 10, 2023

ONIE with secureboot will have <initrd.img-5.4.86-onie.sig> and <initrd.img-5.4.86-onie>. The community code doesn't specify to use the <initrd.img-5.4.86-onie> which will impact the ONL installation. Could we modify the pat to <onie/initrd.img*-onie> make it specifically to use the one without sig?
def _g(d): pat = os.path.join(d, "onie/initrd.img*") l = glob.glob(pat) if l: return l[0] return None
From <packages/base/all/vendor-config-onl/src/python/onl/install/ShellApp.py> line 109.

@ingridcelestica
Copy link
Contributor Author

@sonoble Could you please help check this issue?Thank you.

@sonoble
Copy link
Contributor

sonoble commented Oct 11, 2023

Hello, this appears to be secure grub in ONIE : https://github.com/opencomputeproject/onie/blob/master/build-config/make/grub.make I see the issue as we would not pick up the actual initrd, but just a signature file. I will go ahead and see if we do this anywhere else as the kernel is signed also:

` /mnt/onie-boot/onie/initrd.img-5.4.86-onie.sig,

/mnt/onie-boot/onie/vmlinuz-5.4.86-onie.sig,

/mnt/onie-boot/grub/grub_sb.cfg.sig`

@ingridcelestica
Copy link
Contributor Author

Hello, this appears to be secure grub in ONIE : https://github.com/opencomputeproject/onie/blob/master/build-config/make/grub.make I see the issue as we would not pick up the actual initrd, but just a signature file. I will go ahead and see if we do this anywhere else as the kernel is signed also:

` /mnt/onie-boot/onie/initrd.img-5.4.86-onie.sig,

/mnt/onie-boot/onie/vmlinuz-5.4.86-onie.sig,

/mnt/onie-boot/grub/grub_sb.cfg.sig`

Hello. What do you think the way if we add "-onie" to make it specifically point to the file without .sig?

@ingridcelestica
Copy link
Contributor Author

@sonoble Kindly ask is there any update? What's you opinion about the solution I commented above? Thank you.

@ingridcelestica
Copy link
Contributor Author

@sonoble Hi Steven. Any update from you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants