You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a number of small issues that makes logging functionality quite confusing in SAI-Challenger.
SAI-C syncd logging option --loglevel may confuse the user with the native pytest option --log-level. I suggest renaming syncd related option.
--log-level option behavior depends on the selected setup JSON. Example: If there is a PTF dataplane - --log-level is ignored (probably because common/sai_dataplane/ptf/sai_ptf_dataplane.py has a custom logging setup). But if there is a snappi and no PTF - --log-level functions as expected and the user can select desired CLI logging level.
There is no good example in the test cases of how to use logging.
The text was updated successfully, but these errors were encountered:
There are a number of small issues that makes logging functionality quite confusing in SAI-Challenger.
--loglevel
may confuse the user with the native pytest option--log-level
. I suggest renaming syncd related option.--log-level
option behavior depends on the selected setup JSON. Example: If there is a PTF dataplane ---log-level
is ignored (probably becausecommon/sai_dataplane/ptf/sai_ptf_dataplane.py
has a custom logging setup). But if there is a snappi and no PTF ---log-level
functions as expected and the user can select desired CLI logging level.The text was updated successfully, but these errors were encountered: