Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging configuration is not consistent and depend on setup file #32

Open
anton7811 opened this issue Jan 27, 2023 · 0 comments
Open

Logging configuration is not consistent and depend on setup file #32

anton7811 opened this issue Jan 27, 2023 · 0 comments

Comments

@anton7811
Copy link
Collaborator

There are a number of small issues that makes logging functionality quite confusing in SAI-Challenger.

  1. SAI-C syncd logging option --loglevel may confuse the user with the native pytest option --log-level. I suggest renaming syncd related option.
  2. --log-level option behavior depends on the selected setup JSON. Example: If there is a PTF dataplane - --log-level is ignored (probably because common/sai_dataplane/ptf/sai_ptf_dataplane.py has a custom logging setup). But if there is a snappi and no PTF - --log-level functions as expected and the user can select desired CLI logging level.
  3. There is no good example in the test cases of how to use logging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant