Feat/dp 1.14 dscp transparency with ecn #2571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #2571 / 0d6e128Virtual Devices
Hardware Devices
|
cm-nokia
added
the
new-requirement-pr
Pull Request Test Coverage Report for Build 12897290974Details
💛 - Coveralls |
cm-nokia
force-pushed
the
feat/DP-1.14-DSCP-Transparency-with-ECN
branch
from
bb2758a to
8712ea1
Compare
|
fixes #2077 |
cfernanz
reviewed
Apr 1, 2024
There was a problem hiding this comment.
Please also update
featureprofiles/testregistry.textproto
Lines 279 to 284 in 6342007
test: {
id: "DP-1.14"
description: "QoS basic test"
readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/qos/otg_tests/qos_basic_test/README.md"
exec: " "
}
test: {
id: "DP-1.15"
description: "DSCP transperency with ECN"
readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/qos/ecn/otg_tests/dscp_transparency_test/README.md"
exec: " "
}
sezhang2
reviewed
Jan 5, 2025
| platform: { | ||
| vendor: NOKIA | ||
| } | ||
| deviations: { |
There was a problem hiding this comment.
Please open bugs to track the deviations.
There was a problem hiding this comment.
Below are the internal bugs created for tracking:
explicit_interface_in_default_vrf -- b/358493728
interface_enabled -- b/358493729
qos_queue_requires_id -- b/358622716
qos_buffer_allocation_config_required -- b/358686264
sezhang2
reviewed
Jan 5, 2025
| @@ -0,0 +1,913 @@ | |||
| // Copyright 2022 Google LLC | |||
sezhang2
reviewed
Jan 5, 2025
sezhang2
previously approved these changes
Jan 5, 2025
|
/fptest physical |
|
@cm-nokia Can you add test result and log after the code is updated? |
…t/DP-1.14-DSCP-Transparency-with-ECN
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
…t/DP-1.14-DSCP-Transparency-with-ECN
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Test log is available at b/391393101. Also updated test-id to use DP-1.17 due to conflicts with other tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: stole dp-1.15 for test id since the qos_basic test seems to be using dp-1.14 already.
fixes #2077 (edit to add here so gh links it up to issue nicer)
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."