Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need clarity on credentialz.proto host certificate rotation #91

Open
dhilipkr opened this issue Jul 7, 2023 · 3 comments
Open

Need clarity on credentialz.proto host certificate rotation #91

dhilipkr opened this issue Jul 7, 2023 · 3 comments

Comments

@dhilipkr
Copy link

dhilipkr commented Jul 7, 2023

The ServerKeysRequest message has auth_artifacts that holds a field for 'certificate'. But there are no fields to know the type of certificate. So while writing this new certificate to the file system, how do we establish the file name ? whether it should be /etc/ssh/ssh_host_rsa_key-cert.pub or /etc/ssh/ssh_host_ecdsa-cert.pub?
Is the RPC handler supposed to parse the certificate as in ssh-keygen -L -f and determine the type and do this?

@morrowc
Copy link
Contributor

morrowc commented Dec 28, 2024

Are you proposing that we add to the ServerKeysRequest a key-type, like: (perhaps just require this enum actually)

enum KeyGen {

in order to tell what form key is being sent?
(I don't think openconfig itself cares a ton about 8.3 filenames.. eh? but it may be handy to know: "oh this is a widget-form key" for other reasons?)

@dhilipkr
Copy link
Author

dhilipkr commented Jan 7, 2025

I don't think we need this change anymore. I created this during the initial phase of the implementation for handling the ServerKeysRequest. Identified that SSHD config's 'HostCertificate' parameter just needs to point to a file path where the certificate is stored. So it wouldn't matter to know what the key type is for this case.

@morrowc
Copy link
Contributor

morrowc commented Jan 8, 2025

sounds ok to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants