Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oci-image-tool commands ‘validate’ and ‘create’ failing for tar and zip images #205

Open
knieriem opened this issue Jun 10, 2018 · 1 comment · May be fixed by #206
Open

oci-image-tool commands ‘validate’ and ‘create’ failing for tar and zip images #205

knieriem opened this issue Jun 10, 2018 · 1 comment · May be fixed by #206

Comments

@knieriem
Copy link

Due to a change in rev. 9027d58 validating an image in a tar (or zip) file is failing currently with the following message:

<tar-image>: find failed: unable to walk: end of walk

This is because in the context of the transition from using w.walk to w.find in findManifest (and, similar, findConfig) which has been done in 9027d58, the interaction between walk/findFunc and error handling, especially regarding errEOW, appears not to have been adjusted accordingly.

I have created a patch knieriem@06a4e96 that describes in more detail what is happening, and adjusts how image.findManifest and image.findConfig interact with image.walker.find so that validate and create commands work again for tar and zip files.

@zhouhao3
Copy link

@knieriem Can you push that patch to this community to solve this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants