Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal ListSets support #10

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mkancija
Copy link

Server.php to allow ListSets verb.

index.php with ListSets callback method, added set arg to ListRecords callback method.
When set is defined, listRecords method replaces plain record list with record list based on set - metadataPrefix scope.

Edited Stylesheet.xsl to show ListSets button on ListMetadataFormats page.
Main.template.php contains new ListSets key with example sets.

Example of directory structure for MODS metadataPrefix:

original/records path:
oaipmh_root/mods/123456789.xml
oaipmh_root/mods/234567891.xml

sets with records path:
oaipmh_root/sets/10001/mods/123456789.xml
oaipmh_root/sets/10001/mods/234567891.xml

todo:
ListSets foreach loop should replace metadataPrefix when listsets are defined, and sets exist.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sebastian-meyer sebastian-meyer marked this pull request as draft July 13, 2023 18:13
@mkancija mkancija marked this pull request as ready for review July 14, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants