Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change some terminals to rules in the grammar #378

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Change some terminals to rules in the grammar #378

merged 2 commits into from
Jul 20, 2023

Conversation

pcoccoli
Copy link
Collaborator

Fixes #371

@pcoccoli pcoccoli requested a review from subbyte July 18, 2023 20:27
@pcoccoli pcoccoli self-assigned this Jul 18, 2023
@pcoccoli pcoccoli mentioned this pull request Jul 18, 2023
Closed
@codecov
Copy link

codecov bot commented Jul 18, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.31 🎉

Comparison is base (18d6f98) 83.60% compared to head (7fe9309) 83.91%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #378      +/-   ##
===========================================
+ Coverage    83.60%   83.91%   +0.31%     
===========================================
  Files           49       49              
  Lines         3086     3134      +48     
===========================================
+ Hits          2580     2630      +50     
+ Misses         506      504       -2
Impacted Files Coverage Δ
src/kestrel/syntax/parser.py 97.87% <100.00%> (+0.63%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

subbyte
subbyte reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@subbyte subbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I go through the change and may find some typos and simplifications.

src/kestrel/syntax/kestrel.lark Show resolved Hide resolved
src/kestrel/syntax/kestrel.lark Outdated Show resolved Hide resolved
src/kestrel/syntax/parser.py Outdated Show resolved Hide resolved
src/kestrel/syntax/kestrel.lark Show resolved Hide resolved
src/kestrel/syntax/parser.py Outdated Show resolved Hide resolved
subbyte
subbyte approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@subbyte subbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pcoccoli pcoccoli mentioned this pull request Jul 20, 2023
Closed
@pcoccoli pcoccoli merged commit cfcd2b4 into develop Jul 20, 2023
@pcoccoli pcoccoli deleted the issue_371_rules_to_terminals branch July 20, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subbyte subbyte subbyte approved these changes

Assignees

@pcoccoli pcoccoli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the terminals in grammar file with lower cases to workaround the bug of lark-js
2 participants
@pcoccoli @subbyte