-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model_id is mandatory for model queries but it can have any values #165
Comments
Interesting, this should be a Caikit... bug...? That does indicate some weirdness in the finder for the models, but I'm not sure this is a big problem with how we use the Caikit component here xD |
We can keep this open for now |
Let's keep this open for now, I'm not sure what the intended behavior is |
Thanks for pointing this out! In general, There are a couple of things we can do to make this better:
|
thanks for the explanation Gabe. What about setting the desired behavior with an Env variable? maybe for someone having the lazy discover of the model is a desired feature. In that case, the parameter could be make optional, for example |
in order to query a model using caikit+TGIS runtime, we must pass the
model_id
parameter in the HTTP payload (ormm-model-id
for grpc).However, it can have any value and as far as the endpoint is correct, the model responses.
In the following screenshot you can see 3 calls:
The text was updated successfully, but these errors were encountered: