Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model_id is mandatory for model queries but it can have any values #165

Open
bdattoma opened this issue Nov 20, 2023 · 6 comments
Open

model_id is mandatory for model queries but it can have any values #165

bdattoma opened this issue Nov 20, 2023 · 6 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@bdattoma
Copy link
Contributor

in order to query a model using caikit+TGIS runtime, we must pass the model_id parameter in the HTTP payload (or mm-model-id for grpc).
However, it can have any value and as far as the endpoint is correct, the model responses.

In the following screenshot you can see 3 calls:

  1. first one using the actual model id
  2. second one using a dummy model id
  3. third one without the model id parameter

image

@dtrifiro dtrifiro self-assigned this Nov 20, 2023
@heyselbi heyselbi added the kind/bug Something isn't working label Nov 30, 2023
@Xaenalt
Copy link
Member

Xaenalt commented Dec 6, 2023

Interesting, this should be a Caikit... bug...? That does indicate some weirdness in the finder for the models, but I'm not sure this is a big problem with how we use the Caikit component here xD

@bdattoma
Copy link
Contributor Author

@Xaenalt @dtrifiro what should we do with this ticket?

@dtrifiro
Copy link
Contributor

We can keep this open for now

@Xaenalt
Copy link
Member

Xaenalt commented Jan 23, 2024

Let's keep this open for now, I'm not sure what the intended behavior is
@gabe-l-hart @gkumbhat @evaline-ju

@gabe-l-hart
Copy link

Thanks for pointing this out! In general, caikit.runtime is designed to be a multi-tenanted server, serving multiple models per instance. For that reason, the id is required. The reason this is "working" with random ids had to do with how models are lazily discovered. With the TgisAutoFinder, any unknown id will act as a shim to TGIS.

There are a couple of things we can do to make this better:

  • Limit the model ids allowed through the TgisAutoFinder so only the "right" id works
  • Explore a default model id that gets used when none is present in the request

@bdattoma
Copy link
Contributor Author

  • at gets used w

thanks for the explanation Gabe.

What about setting the desired behavior with an Env variable? maybe for someone having the lazy discover of the model is a desired feature. In that case, the parameter could be make optional, for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: To-do/Groomed
Development

No branches or pull requests

5 participants