From 198fd71d24384811962d338a41cc2b8aab499936 Mon Sep 17 00:00:00 2001 From: Alessio Pragliola <83355398+Al-Pragliola@users.noreply.github.com> Date: Thu, 19 Dec 2024 04:53:50 +0100 Subject: [PATCH] fix(mr): bug not filling params.env with default cert value (#1457) Signed-off-by: Alessio Pragliola --- .../components/modelregistry/modelregistry.go | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/controllers/components/modelregistry/modelregistry.go b/controllers/components/modelregistry/modelregistry.go index 6784099207a..c79519e347a 100644 --- a/controllers/components/modelregistry/modelregistry.go +++ b/controllers/components/modelregistry/modelregistry.go @@ -41,16 +41,8 @@ func (s *componentHandler) GetManagementState(dsc *dscv1.DataScienceCluster) ope func (s *componentHandler) Init(_ cluster.Platform) error { mi := baseManifestInfo(BaseManifestsSourcePath) - params := make(map[string]string) - for k, v := range imagesMap { - params[k] = v - } - for k, v := range extraParamsMap { - params[k] = v - } - - if err := odhdeploy.ApplyParams(mi.String(), params); err != nil { - return fmt.Errorf("failed to update images on path %s: %w", mi, err) + if err := odhdeploy.ApplyParams(mi.String(), imagesMap, extraParamsMap); err != nil { + return fmt.Errorf("failed to update params on path %s: %w", mi, err) } return nil