Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

部分函数内增加了设备类型的转换,防止某些只接受"cuda"的函数拿到"gpu"后报错。 #1631

Closed
wants to merge 2 commits into from

Conversation

dium6i
Copy link

@dium6i dium6i commented Jan 25, 2025

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

部分函数内增加了设备类型的转换,防止某些只接受"cuda"的函数拿到"gpu"后报错。

Modification

部分函数内增加了设备类型的转换,防止某些只接受"cuda"的函数拿到"gpu"后报错。

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Copy link
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@dium6i
Copy link
Author

dium6i commented Jan 25, 2025

自己在测试的时候发现的问题,部分函数只接受cpu、cuda这样的设备类型,配置文件里修改为gpu后,会报错。

PR仅供参考,不一定是最好的解决方案。

@myhloli
Copy link
Collaborator

myhloli commented Jan 25, 2025

合法的device类型只有cpu、cuda、mps、npu,用户在device中输入gpu是预期之外的。我们不推荐把gpu直接映射为cuda,因为gpu其实是个非常笼统的概括,包括Nvidia,AMD,甚至一些国产型号,在device的命名中应当遵循torch的官方定义。

@dium6i
Copy link
Author

dium6i commented Jan 25, 2025

了解了。之前用其他框架只有cpu和gpu的选项,测试的时候就直接把cpu改成gpu了。

@dium6i dium6i closed this Jan 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants