Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry logic for failed subscriptions after reconnect #34

Open
jbarlow-mcafee opened this issue Sep 5, 2018 · 0 comments
Open

Retry logic for failed subscriptions after reconnect #34

jbarlow-mcafee opened this issue Sep 5, 2018 · 0 comments
Labels

Comments

@jbarlow-mcafee
Copy link
Contributor

Currently, the on_connect_run logic in the client attempts to resubscribe for all previously subscribed topics when a reconnect occurs. This logic happens here. If any subscriptions were to fail, the current logic just writes out an error to the console but does not retry the attempt at a later time. This could leave the client in a state where some subscriptions are unexpectedly not active until / unless the client happens to reconnect again. There should be some additional logic added to retry the failed subscriptions - perhaps by triggering the full disconnect / reconnect sequence up to the number of connect retries which have been configured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant