Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

feat: [FC-0006] verifiable credentials feature backport to Palm #6971

Conversation

GlugovGrGlib
Copy link
Contributor

This PR is backport for Verifiable credentials functionality into open-release/palm.master

Credentials repository backport: openedx/credentials#2110
frontend-app-learner-record repository backport: openedx/frontend-app-learner-record#169

Verifiable Credentails documentation: https://edx-credentials.readthedocs.io/en/latest/verifiable_credentials/overview.html


Configuration Pull Request

Make sure that the following steps are done before merging:

  • A SRE team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
  • Are you adding any new default values that need to be overridden when this change goes live? If so:
    • Update the appropriate internal repo (be sure to update for all our environments)
    • If you are updating a secure value rather than an internal one, file a SRE ticket with details.
    • Add an entry to the CHANGELOG.
  • If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
  • Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?

RG and others added 2 commits August 2, 2023 00:14
This changes allow to configure Verifiable Credentials settings for the "credentials"
service.

Related tickets:
* [OeX_Cred-426](https://youtrack.raccoongang.com/issue/OeX_Cred-426)
* feat: [OeX_Cred-790] add comment about verifiable credentials documentation

* docs: remove resolved TODO

---------

Co-authored-by: Glib Glugovskiy <[email protected]>
@GlugovGrGlib GlugovGrGlib changed the title feat: [FC-0006] verifiable credentials feature backport feat: [FC-0006] verifiable credentials feature backport to Palm Aug 1, 2023
Copy link

@wowkalucky wowkalucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Ok.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 3, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @GlugovGrGlib! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 requested a review from e0d August 22, 2023 18:01
@mphilbrick211
Copy link

Hi @e0d - are you able to merge this?

@e0d
Copy link
Contributor

e0d commented Aug 22, 2023

@jalondonot Any objections if I merge this backport PR?

Copy link
Contributor

@e0d e0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jalondonot
Copy link

No objections so far, @e0d :)

@e0d e0d merged commit ea82c5a into openedx-unsupported:open-release/palm.master Aug 23, 2023
3 checks passed
@openedx-webhooks
Copy link

@GlugovGrGlib 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@GlugovGrGlib GlugovGrGlib deleted the feat/verifiable_credentials_backport branch August 23, 2023 17:50
@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants