Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate newly converted MFEs into the comprehensive theming system #438

Closed
jmakowski1123 opened this issue Aug 15, 2022 · 2 comments
Closed
Labels
epic Large unit of work, consisting of multiple tasks

Comments

@jmakowski1123
Copy link

Contingent on completing openedx/wg-frontend#156

@arbrandes arbrandes added the epic Large unit of work, consisting of multiple tasks label Oct 6, 2022
@davidjoy
Copy link

Just a quick note, and I'd love to talk about this more - I strongly suggest we don't do this. Rather, we should create more well-supported and well-documented customization methods that don't rely on a blanket 'overlay' of code. The comp theming system is akin to forking the repository in terms of maintainability, which is to say, it makes maintaining the theme code very difficult. We have other options available to us that are almost equally powerful and far more documentable/maintainable/supportable.

@arbrandes
Copy link
Contributor

Yeah, this is an old ticket. We've moved on from this idea since it was first proposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Large unit of work, consisting of multiple tasks
Projects
Status: Closed
Development

No branches or pull requests

3 participants