feat: create ORA "date_config_type" field #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leangseu-edx
force-pushed
the
lk/no-dates-field
branch
2 times, most recently
from
712dcbb
to
46db09f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2013 +/- ##
=======================================
Coverage 95.09% 95.09%
=======================================
Files 158 158
Lines 17420 17446 +26
Branches 1622 1625 +3
=======================================
+ Hits 16566 16591 +25
Misses 641 641
- Partials 213 214 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
jansenk
requested changes
Aug 4, 2023
There was a problem hiding this comment.
This is entirely my fault - I forgot to hit "save" on this ticket when I was changing the description. I have gone in and updated the description to the changes we actually want. This is a perfectly valid implementation of the ticket as it was handed to you but isn't actually what we want to do. I take full responsibility for this mistake.
leangseu-edx
force-pushed
the
lk/no-dates-field
branch
from
d5f186e
to
b77b1a4
Compare
leangseu-edx
changed the title
jansenk
requested changes
Aug 14, 2023
leangseu-edx
force-pushed
the
lk/no-dates-field
branch
from
4465bc0
to
f403aa9
Compare
jansenk
approved these changes
Aug 17, 2023
muselesscreator
added a commit
that referenced
this pull request
Aug 21, 2023
* Mattcarter/au-1388 fix make local install (#2018) * chore: update make install-local-ora to reference cms rather than studio * chore: version bump * feat: create ORA "date_config_type" field (#2013) * feat: add date_config_type field * docs: remove finished TODO * chore(i18n): update translations --------- Co-authored-by: Matthew Carter <[email protected]> Co-authored-by: leangseu-edx <[email protected]> Co-authored-by: Ned Batchelder <[email protected]> Co-authored-by: Jenkins <[email protected]>
BryanttV
pushed a commit
to eduNEXT/edx-ora2
that referenced
this pull request
Feb 6, 2024
* feat: add date_config_type field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR - add no_dates field to xblock and let ora use course start, end date.
JIRA: https://2u-internal.atlassian.net/browse/AU-1314
What changed?
date_config_typemanual,subsectionandcourse_endNOTE: this only work with lms.
runtimelibs does not seem to work in studio.is_course_staffalso not working on studio, so I assume this is acceptable.Developer Checklist
Testing Instructions
[ How should a reviewer test this PR? ]
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora