-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add studio ui for date config type #2030
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2030 +/- ##
=======================================
Coverage 95.09% 95.10%
=======================================
Files 158 158
Lines 17446 17450 +4
Branches 1625 1625
=======================================
+ Hits 16591 16595 +4
Misses 641 641
Partials 214 214
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
a4ac3c8
to
70290ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great but there were some comments from gabe I had in the ticket under the screenshots that it looks like you might have missed:
Include the following changes to the above concept:
set label for the radio buttons. Something along the lines of "Select a deadline configuration option"
Adjust the text for each radio:
- Configure deadlines manually
- Match deadlines to the subsection due date
- Match deadlines to the course end date
48d57ff
to
047bde3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
* chore: add studio ui for date config type * chore: update tests
schedule-ui.mov
studio-ui-2.mov
JIRA: https://2u-internal.atlassian.net/browse/AU-1315
Developer Checklist
Testing Instructions
[ How should a reviewer test this PR? ]
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora