Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add studio ui for date config type #2030

Merged
merged 16 commits into from
Aug 24, 2023
Merged

chore: add studio ui for date config type #2030

merged 16 commits into from
Aug 24, 2023

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented Aug 16, 2023

  • chore: add studio ui for date config type

image

schedule-ui.mov
studio-ui-2.mov

JIRA: https://2u-internal.atlassian.net/browse/AU-1315

Developer Checklist

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@leangseu-edx leangseu-edx requested a review from a team as a code owner August 16, 2023 19:05
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0c3f7b3) 95.09% compared to head (9bc9cc9) 95.10%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2030   +/-   ##
=======================================
  Coverage   95.09%   95.10%           
=======================================
  Files         158      158           
  Lines       17446    17450    +4     
  Branches     1625     1625           
=======================================
+ Hits        16591    16595    +4     
  Misses        641      641           
  Partials      214      214           
Flag Coverage Δ
unittests 95.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
openassessment/xblock/test/test_studio.py 99.01% <ø> (ø)
openassessment/xblock/schema.py 81.48% <100.00%> (+1.48%) ⬆️
openassessment/xblock/studio_mixin.py 93.29% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from lk/no-dates-field to master August 17, 2023 14:34
Copy link
Contributor

@jansenk jansenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great but there were some comments from gabe I had in the ticket under the screenshots that it looks like you might have missed:

Include the following changes to the above concept:

set label for the radio buttons. Something along the lines of "Select a deadline configuration option"

Adjust the text for each radio:

- Configure deadlines manually
- Match deadlines to the subsection due date
- Match deadlines to the course end date

@leangseu-edx leangseu-edx requested a review from a team August 22, 2023 14:07
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@leangseu-edx leangseu-edx merged commit 99d711a into master Aug 24, 2023
6 checks passed
@leangseu-edx leangseu-edx deleted the lk/studio-ui branch August 24, 2023 18:55
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this pull request Feb 6, 2024
* chore: add studio ui for date config type

* chore: update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants