Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make lease expiration times configurable #2217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0x29a
Copy link
Contributor

@0x29a 0x29a commented Jul 16, 2024

Description

By default, ORA hands off an assignment for which a peer review hasn’t been submitted to the next learner after 8 hours - some learners start a peer review, then come back the next morning and find the response gone. This PR makes lease expiration times configurable, thus preventing responses from disappearing if they're set to 24 hours, for example.

Testing instructions

  1. Set both settings to 1.
  2. Start a peer review, but don't submit anything.
  3. After an hour, verify that your assignment has been handed off.

private-ref

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 16, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 16, 2024

Thanks for the pull request, @0x29a!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-aurora. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.09%. Comparing base (8b320d6) to head (63e5e0c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2217   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files         195      195           
  Lines       21479    21481    +2     
  Branches     1931     1931           
=======================================
+ Hits        20425    20427    +2     
  Misses        787      787           
  Partials      267      267           
Flag Coverage Δ
unittests 95.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0x29a 0x29a force-pushed the 0x29a/BB-8990/configurable-lease-expiration-time branch from a533271 to e64bca4 Compare July 16, 2024 11:18
@0x29a 0x29a force-pushed the 0x29a/BB-8990/configurable-lease-expiration-time branch from e64bca4 to 63e5e0c Compare July 16, 2024 13:29
@itsjeyd
Copy link

itsjeyd commented Sep 7, 2024

Hey @0x29a, just checking in to see if this PR is still needed?

@itsjeyd itsjeyd added the inactive PR author has been unresponsive for several months label Sep 7, 2024
@0x29a 0x29a marked this pull request as ready for review September 10, 2024 11:24
@0x29a 0x29a requested a review from a team as a code owner September 10, 2024 11:24
@0x29a
Copy link
Contributor Author

0x29a commented Sep 10, 2024

@itsjeyd, yes, it is. I updated the description and marked it as ready for review.

@0x29a 0x29a changed the title feat: make lease expiration times configurable [WIP] feat: make lease expiration times configurable Sep 10, 2024
@itsjeyd itsjeyd added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed inactive PR author has been unresponsive for several months labels Sep 11, 2024
@itsjeyd itsjeyd requested a review from a team September 11, 2024 08:21
@itsjeyd
Copy link

itsjeyd commented Sep 11, 2024

Thanks @0x29a. I requested a review from the maintaining team (see "Who will review my changes?" above).

Hey @openedx/2u-aurora, please have a look at this PR when you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants