Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: course name missing from ORA notification context #2220

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

eemaanamir
Copy link
Contributor

Ticket: INF-1462

The course name was missing from the context of the ORA notification.

Before:

image-20240709-072858

After:

Screenshot 2024-07-31 at 11 48 04 AM

@eemaanamir eemaanamir requested a review from a team as a code owner July 31, 2024 07:00
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.09%. Comparing base (8b320d6) to head (ab43843).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2220   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files         195      195           
  Lines       21479    21485    +6     
  Branches     1931     1931           
=======================================
+ Hits        20425    20431    +6     
  Misses        787      787           
  Partials      267      267           
Flag Coverage Δ
unittests 95.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AhtishamShahid AhtishamShahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update version of this package . and after approval and merging create new release as well.

@eemaanamir eemaanamir merged commit 3b29778 into master Aug 2, 2024
11 checks passed
@eemaanamir eemaanamir deleted the INF-1462 branch August 2, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants