From 18cf33864d47ccebefabee4067e30a3eaa7ed080 Mon Sep 17 00:00:00 2001 From: Brian Mesick Date: Thu, 9 Jan 2025 15:36:03 -0500 Subject: [PATCH 1/2] build: Log in to dockerhub for unit test CI We're being rate limited by dockerhub for pulling too many images in CI. There isn't a greate solution for caching images for GH actions, but in theory we should have less strict limits as an authenticated user. --- .github/workflows/unit-tests.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index c635972d5f4..039e7ec82c5 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -73,6 +73,12 @@ jobs: run: | sudo apt-get update && sudo apt-get install libmysqlclient-dev libxmlsec1-dev lynx + - name: Login to Docker Hub + uses: docker/login-action@v3.3.0 + with: + username: ${{ secrets.DOCKERHUB_USERNAME }} + password: ${{ secrets.DOCKERHUB_TOKEN }} + - name: Start MongoDB uses: supercharge/mongodb-github-action@1.11.0 with: @@ -197,7 +203,6 @@ jobs: to add any missing apps and match the count. for more details please take a look at scripts/gha-shards-readme.md" exit 1 - # This job aggregates test results. It's the required check for branch protection. # https://github.com/marketplace/actions/alls-green#why # https://github.com/orgs/community/discussions/33579 From 042c0441b072cfe57bb6556e1bc3f46ea1547db8 Mon Sep 17 00:00:00 2001 From: Brian Mesick Date: Thu, 9 Jan 2025 15:41:21 -0500 Subject: [PATCH 2/2] fix: Use correct secret name for dockerhub password --- .github/workflows/unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 039e7ec82c5..46b27d51a77 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -77,7 +77,7 @@ jobs: uses: docker/login-action@v3.3.0 with: username: ${{ secrets.DOCKERHUB_USERNAME }} - password: ${{ secrets.DOCKERHUB_TOKEN }} + password: ${{ secrets.DOCKERHUB_PASSWORD }} - name: Start MongoDB uses: supercharge/mongodb-github-action@1.11.0