Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added maxLength and default tip for email subject #153

Conversation

Inferato
Copy link
Contributor

@Inferato Inferato commented Oct 6, 2023

If the user puts more than 128 symbols in the email subject it causes an error.
Added length restriction and field tip.
Related PR: #154

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 6, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 6, 2023

Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 requested a review from a team October 6, 2023 13:47
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 6, 2023
@arbrandes
Copy link
Contributor

Mind linking to the PR to master in the description?

@arbrandes
Copy link
Contributor

(And also linking to this PR from the one to master.)

@mphilbrick211 mphilbrick211 removed the request for review from a team October 10, 2023 18:43
@mphilbrick211 mphilbrick211 removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 10, 2023
@Inferato
Copy link
Contributor Author

(And also linking to this PR from the one to master.)

Done

@Inferato
Copy link
Contributor Author

@mphilbrick211 Pls recheck PR and add comments if needed

@mphilbrick211
Copy link

@mphilbrick211 Pls recheck PR and add comments if needed

@arbrandes - I think this is ready for you!

@Inferato
Copy link
Contributor Author

@arbrandes This is ready for review.

@arbrandes
Copy link
Contributor

We need to merge the one to master first, and in that one I'm still missing a screenshot with the feature being introduced.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Nov 28, 2023
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 21, 2024
@mphilbrick211
Copy link

@arbrandes - can this be merged now that the master is all set?

@dyudyunov
Copy link
Contributor

Hi
I think that there is no sense in merging into the Palm branch.

I propose to close the PR. I will create a backport to Quince instead

@dyudyunov
Copy link
Contributor

I've added a backport PR for Quince #196

@dyudyunov dyudyunov closed this Feb 28, 2024
@openedx-webhooks
Copy link

@Inferato Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants