-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added maxLength and default tip for email subject #153
fix: Added maxLength and default tip for email subject #153
Conversation
Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Mind linking to the PR to master in the description? |
(And also linking to this PR from the one to master.) |
Done |
@mphilbrick211 Pls recheck PR and add comments if needed |
@arbrandes - I think this is ready for you! |
@arbrandes This is ready for review. |
We need to merge the one to master first, and in that one I'm still missing a screenshot with the feature being introduced. |
@arbrandes - can this be merged now that the master is all set? |
Hi I propose to close the PR. I will create a backport to Quince instead |
I've added a backport PR for Quince #196 |
@Inferato Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
If the user puts more than 128 symbols in the email subject it causes an error.
Added length restriction and field tip.
Related PR: #154