Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unenrolling from Course is not working #269

Closed
hinakhadim opened this issue Jan 11, 2024 · 5 comments
Closed

Unenrolling from Course is not working #269

hinakhadim opened this issue Jan 11, 2024 · 5 comments
Labels
needs maintainer attention Issue or PR specifically needs the attention of the maintainer.

Comments

@hinakhadim
Copy link
Contributor

When I try to unenroll from a course, the API gives error. As the API is requesting the default .env.development variable which is http://localhost:18000. But it should request to LMS_BASE_URL provided in the MFE_CONFIG settings. When printing the getConfig().LMS_BASE_URL , it is printing the correct URL.
image

@hinakhadim
Copy link
Contributor Author

Further debugging leads me to this conclusion:
Here, the variable is setting the first time value of LMS_BASE_URL because till then mergeConfig hasn't been run.
For further reading, This link can be helpful. Link

I believe making courseUneroll a function instead of a variable will fix the issue, so that courseUnenroll url picks the latest/current value of LMS_BASE_URL. If this seems good, I am willing to work on it.

hinakhadim added a commit to edly-io/frontend-app-learner-dashboard that referenced this issue Jan 15, 2024
hinakhadim added a commit to edly-io/frontend-app-learner-dashboard that referenced this issue Feb 6, 2024
hinakhadim added a commit to edly-io/frontend-app-learner-dashboard that referenced this issue Feb 7, 2024
mariajgrimaldi pushed a commit to eduNEXT/frontend-app-learner-dashboard that referenced this issue Feb 7, 2024
mariajgrimaldi pushed a commit to eduNEXT/frontend-app-learner-dashboard that referenced this issue Feb 7, 2024
ghassanmas pushed a commit to Abstract-Tech/community-theme-learner-dashboard that referenced this issue Apr 12, 2024
@deborahgu deborahgu added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Jul 12, 2024
@justinhynes
Copy link
Contributor

Thanks for your report! The Aperture team will be tracking this internally as ticket APER-3566.

@justinhynes justinhynes added needs maintainer attention Issue or PR specifically needs the attention of the maintainer. and removed needs maintainer attention Issue or PR specifically needs the attention of the maintainer. labels Jul 17, 2024
@jsnwesson
Copy link
Contributor

Hi @hinakhadim , the Aperture and I talked about this issue during our meeting, and we're okay with you continuing to pursue a fix for this if you have the time. I think your approach of converting the variable into a function to fetch the appropriate URL is a viable option. Let us know if you have any questions!

@hinakhadim
Copy link
Contributor Author

Hey everyone,
Thanks for your time. I think that this issue should close automatically after merging this PR.

@jsnwesson
Copy link
Contributor

#273 closes this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs maintainer attention Issue or PR specifically needs the attention of the maintainer.
Projects
Status: Done
Development

No branches or pull requests

4 participants