Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lk/unit test #185

Merged
merged 26 commits into from
Feb 14, 2024
Merged

Lk/unit test #185

merged 26 commits into from
Feb 14, 2024

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented Feb 5, 2024

Mostly just tests

Review instruction:

  • for snapshot: look for fault on something like <Component> or some missing icon.
  • for hooks: read the test text if it align with what the test is doing.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ecca975) 76.98% compared to head (e4df4bc) 91.21%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #185       +/-   ##
===========================================
+ Coverage   76.98%   91.21%   +14.22%     
===========================================
  Files         163      129       -34     
  Lines        1860     1673      -187     
  Branches      441      373       -68     
===========================================
+ Hits         1432     1526       +94     
+ Misses        410      138      -272     
+ Partials       18        9        -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leangseu-edx leangseu-edx merged commit f745954 into master Feb 14, 2024
6 checks passed
@leangseu-edx leangseu-edx deleted the lk/unit-test branch February 14, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant