Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add default prompt header #180

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented Jan 31, 2024

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2083818) 76.96% compared to head (267ea9f) 76.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   76.96%   76.98%   +0.02%     
==========================================
  Files         163      163              
  Lines        1858     1860       +2     
  Branches      440      441       +1     
==========================================
+ Hits         1430     1432       +2     
  Misses        410      410              
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leangseu-edx leangseu-edx force-pushed the lk/add-staff-prompt-header branch from fcd5cb4 to 1348e17 Compare January 31, 2024 15:43
@leangseu-edx leangseu-edx changed the title chore: add staff prompt header chore: add default prompt header Jan 31, 2024
@@ -27,6 +27,11 @@ const messages = defineMessages({
description: 'Done step prompt header',
id: 'frontend-app-ora.Prompt.header.done',
},
promptTitle: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what I think about this as a default value but I also don't think it really matters

@leangseu-edx leangseu-edx force-pushed the lk/add-staff-prompt-header branch from 784677c to 267ea9f Compare February 1, 2024 15:03
@leangseu-edx leangseu-edx merged commit 0639b27 into master Feb 1, 2024
6 checks passed
@leangseu-edx leangseu-edx deleted the lk/add-staff-prompt-header branch February 1, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants