Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use country-state-city to populate state dropdown in StateProvinceFormInput #849

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

julianajlk
Copy link
Contributor

@julianajlk julianajlk commented Feb 7, 2024

REV-3842.

Removing the hard coded states for Canada, US, and India in countryStatesMap.js and using the country-state-city library to populate states for all countries that have states in the ISO 3166-2 list. Sonic version of the payment page will use this library as well. This is done in preparation for offering Dynamic Payment Methods, where the Stripe API requires state/zip code for BNPL payment methods.

Note:: If the country has states/provinces/regions/countries/districts, state field will be populated and will become a REQUIRED field.

@julianajlk julianajlk requested a review from a team as a code owner February 7, 2024 17:48
@zubair-ce07
Copy link
Contributor

LGTM 👍

@julianajlk julianajlk force-pushed the julianajlk/REV-3842/populate-state-field-dropdown branch from ad3298d to eb47ec2 Compare February 20, 2024 12:40
@julianajlk julianajlk merged commit 58cde5d into master Feb 20, 2024
5 checks passed
@julianajlk julianajlk deleted the julianajlk/REV-3842/populate-state-field-dropdown branch February 20, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants