Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New master #874

Closed
wants to merge 26 commits into from
Closed

New master #874

wants to merge 26 commits into from

Conversation

bdizha
Copy link

@bdizha bdizha commented Jul 5, 2024

Anyone merging to this repository is expected to promptly release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.

Description

Supporting information

Testing instructions

Other information

Checklist

  • Consider PCI compliance impact and whether this PR changes how credit card information is handled.
  • Intend to release and monitor this PR promptly after merge.

christopappas and others added 26 commits April 5, 2024 13:30
@christopappas
docs: updating readme (#1)
b2de60b 
* docs: updating readme

* chore: changing text to trigger GHA

* fix: update CODEOWNERS to be internal revenue-squad
@julianajlk
refactor: Add shipping address for Afterpay, PaymentIntentUnexpectedS…
bdb2358 
…tateError, WIP
@julianajlk
feat: Add DynamicPaymentMethodsNotCompatibleError to handle BNPL DPM …
3f144a9 
…on unsupported countries
@julianajlk
refactor: Postal code required for BNPL DPM supported countries since…
a25976a 
… API expects it
@julianajlk
fix: Update stripe checkout function
4529662
@julianajlk
refactor: Get paymentMethodType onChange and send shipping address on…
a8dddd2 
…ly if afterpay
@julianajlk
feat: Add PaymentMethodMessagingElement, modify currencySelector, use…
7d2222c 
… prod-edx-cf-loc
@julianajlk
refactor: Modify checkout function to handleNextAction for DPM payments
9c00e5f
@julianajlk
fix: Add isPaymentRedirect to selectors for redirect to receipt
eaaed95
@julianajlk
refactor: Modify PaymentPage to account for redirect from DPM and red…
a641b79 
…irect to receipt
@julianajlk
refactor: Use stripe promise from PaymentPage parent in Checkout
ee959b4
@julianajlk
fix: Update invalid_request_error to include error in missing state a…
9b81cc0 
…nd zip code
@julianajlk
fix: Only Klarna has redirect_status on return_url, cannot rely on it
fd2bccc
@julianajlk
fix: Remove no longer needed PaymentIntentUnexpectedStateError, handl…
0a8c584 
…ing from BE instead
@julianajlk
fix: Reorder error type in handleRequestError from feedback
521c606
@julianajlk
test: Add more tests
e1b548d
@julianajlk
fix: Add dpm_enabled query param to receipt URL
b60c260
@julianajlk
fix: Add stripeSelectedPaymentMethod to payment_selected click event
7fa34ad
@julianajlk
Merge pull request #4 from edx/julianajlk/REV-3830/stripe-dpm
85e5f51 
REV-3830
@julianajlk
fix: Add country compatibility with BNPL Affirm at the form level (#5)
d71837f 
REV-3830
@julianajlk
refactor: DPM loading lag for successful payments redirect (#6)
83a63fc 
REV-4009
@julianajlk
chore: Clean up allowlist follow-redirects and webpack-dev-middleware (…
2c35546 
…#9)

REV-3951
@julianajlk
refactor: Reorder DPM successful loading redirect (#8)
0de1892 
REV-4009
@julianajlk
fix: Remove DPM Canada form validation (#10)
bc3becb
@julianajlk
feat: Add PageLoadingDynamicPaymentMethods with timeout for DPM recei…
4aeb2f5 
…pt redirect (#11)

REV-4049
@christopappas
feat: remove cybersource script (#7)
5a61584
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 5, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @bdizha! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@bdizha bdizha closed this Jul 5, 2024
@openedx-webhooks
Copy link

@bdizha Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@bdizha bdizha deleted the new-master branch July 5, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdizha @openedx-webhooks @christopappas @Silidrone @julianajlk