Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated major versions for frontend-platform & paragon #947

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jan 29, 2024

Description

  • Replaced packages @edx/paragon & @edx/frontend-build to use openedx namespace. Updated imports & respective packages (Part of NPM Ownership axim-engineering#23)
  • Major version upgrades, Updating frontend-build to v14 & frontend-platform to v8

@BilalQamar95 BilalQamar95 self-assigned this Jan 29, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.76%. Comparing base (14ac1ab) to head (2d1d723).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #947   +/-   ##
=======================================
  Coverage   67.76%   67.76%           
=======================================
  Files         128      128           
  Lines        3229     3229           
  Branches      913      913           
=======================================
  Hits         2188     2188           
  Misses        996      996           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/frontend-platform-upgrade branch from 0ede69b to 57f16f9 Compare April 24, 2024 13:14
@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/frontend-platform-upgrade branch from 57f16f9 to b74a091 Compare April 24, 2024 13:18
@BilalQamar95
Copy link
Contributor Author

@Ali-D-Akbar can you please merge it as well, I don't have the permission for it

@BilalQamar95
Copy link
Contributor Author

@Ali-D-Akbar can you please merge it as well, I don't have the permission for it

Hey @Ali-D-Akbar, are there any blockers on merging this?

@Ali-D-Akbar
Copy link
Contributor

@BilalQamar95 Hi there, sorry about the delay. This PR requires some good local testing. We'll hopefully get this done this week and let you know if everything is okay and merge it. Thanks.

@BilalQamar95
Copy link
Contributor Author

@BilalQamar95 Hi there, sorry about the delay. This PR requires some good local testing. We'll hopefully get this done this week and let you know if everything is okay and merge it. Thanks.

@Ali-D-Akbar Any updates on when this is going to get merged?

Copy link
Contributor

@AfaqShuaib09 AfaqShuaib09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local, Changes LGTM 👍🏻 , Good to go

@BilalQamar95
Copy link
Contributor Author

@Ali-D-Akbar can you please merge it as well, I don't have the permission for it

@AfaqShuaib09 can you please merge it?

"@edx/openedx-atlas": "^0.6.0",
"@edx/paragon": "^20.44.0",
"@openedx/paragon": "^21.11.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we moving some packages from the edx namespace to openedx?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can view axim-engineering#23 for details. I have also updated the description

@DawoudSheraz DawoudSheraz merged commit b8be886 into openedx:master Aug 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants