fetch restricted runs in publisher #964
Conversation
zawan-ila
force-pushed
the
anawaz/prod-4088
branch
from
4ca9fe8
to
579bc87
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #964 +/- ##
=======================================
Coverage 67.75% 67.76%
=======================================
Files 128 128
Lines 3228 3229 +1
Branches 913 935 +22
=======================================
+ Hits 2187 2188 +1
Misses 996 996
Partials 45 45 ☔ View full report in Codecov by Sentry. |
I don't see many tests for |
| @@ -10,6 +11,7 @@ class DiscoveryDataApiService { | |||
| const queryParams = { | |||
| editable: 1, | |||
| exclude_utm: 1, | |||
| include_restricted: restrictionTypeValues, | |||
There was a problem hiding this comment.
hmmm, do we not need any test updates for this?
There was a problem hiding this comment.
No. There are virtually no tests for this file.
| { value: 'custom-b2c', label: 'Custom B2C' }, | ||
| ]; | ||
|
|
||
| const RESTRICTION_TYPE_VALUES = RESTRICTION_TYPE_OPTIONS.map(opt => opt.value).filter(Boolean).join(','); |
There was a problem hiding this comment.
👍🏽 on that Boolean filter
PROD-4088
This PR adds adds the restriction params to the API calls in Publisher to ensure that restricted runs are always fetched/updated properly in Publisher.
Testing