From fef3c59042ff51bc7940a3abcf6b4c78f652534d Mon Sep 17 00:00:00 2001 From: mashal-m Date: Mon, 25 Sep 2023 16:51:54 +0500 Subject: [PATCH 1/3] refactor: update readMe file --- README.rst | 132 +++++++++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 123 insertions(+), 9 deletions(-) diff --git a/README.rst b/README.rst index d1a03d3dc..1746653cb 100644 --- a/README.rst +++ b/README.rst @@ -5,17 +5,52 @@ frontend-component-footer |Build Status| |Codecov| |npm_version| |npm_downloads| |license| |semantic-release| ******** -Overview +Purpose ******** A generic footer for Open edX micro-frontend applications. It includes a logo and an optional language selector dropdown. -************ +*************** +Getting Started +*************** + +Prerequisites +============= + +The `devstack`_ is currently recommended as a development environment for your +new MFE. If you start it with ``make dev.up.lms`` that should give you +everything you need as a companion to this frontend. + +Note that it is also possible to use `Tutor`_ to develop an MFE. You can refer +to the `relevant tutor-mfe documentation`_ to get started using it. + +.. _Devstack: https://github.com/openedx/devstack + +.. _Tutor: https://github.com/overhangio/tutor + +.. _relevant tutor-mfe documentation: https://github.com/overhangio/tutor-mfe#mfe-development + Requirements -************ +============ This component uses ``@edx/frontend-platform`` services such as i18n, analytics, configuration, and the ``AppContext`` React component, and expects that it has been loaded into a micro-frontend that has been properly initialized via ``@edx/frontend-platform``'s ``initialize`` function. `Please visit the frontend template application to see an example. `_ +Prerequisites +============= + +The `devstack`_ is currently recommended as a development environment for your +new MFE. If you start it with ``make dev.up.lms`` that should give you +everything you need as a companion to this frontend. + +Note that it is also possible to use `Tutor`_ to develop an MFE. You can refer +to the `relevant tutor-mfe documentation`_ to get started using it. + +.. _Devstack: https://github.com/openedx/devstack + +.. _Tutor: https://github.com/overhangio/tutor + +.. _relevant tutor-mfe documentation: https://github.com/overhangio/tutor-mfe#mfe-development + Environment Variables ===================== @@ -24,9 +59,8 @@ This component requires that the following environment variable be set by the co * ``LMS_BASE_URL`` - The URL of the LMS of your Open edX instance. * ``LOGO_TRADEMARK_URL`` - This is a URL to a logo for use in the footer. This is a different environment variable than ``LOGO_URL`` (used in frontend-component-header) to accommodate sites that would like to have additional trademark information on a logo in the footer, such as a (tm) or (r) symbol. -************ Installation -************ +============ To install this footer into your Open edX micro-frontend, run the following command in your MFE: @@ -34,9 +68,33 @@ To install this footer into your Open edX micro-frontend, run the following comm This will make the component available to be imported into your application. -***** +Cloning and Startup +=================== + +.. code-block:: + + + 1. Clone your new repo: + + ``git clone https://github.com/openedx/frontend-component-footer.git`` + + 2. Use node v18.x. + + The current version of the micro-frontend build scripts support node 18. + Using other major versions of node *may* work, but this is unsupported. For + convenience, this repository includes an .nvmrc file to help in setting the + correct node version via `nvm `_. + + 3. Install npm dependencies: + + ``cd frontend-component-footer && npm install`` + + 4. Start the dev server: + + ``npm start`` + Usage -***** +===== This library has the following exports: @@ -71,9 +129,8 @@ Component Usage Example:: * `An example of minimal component and messages usage. `_ * `An example of SCSS file usage. `_ -*********** Development -*********** +=========== Install dependencies:: @@ -87,6 +144,63 @@ Build a production distribution:: npm run build +License +======= + +The code in this repository is licensed under the AGPLv3 unless otherwise +noted. + +Please see `LICENSE `_ for details. + +Contributing +============ + +Contributions are very welcome. Please read `How To Contribute`_ for details. + +.. _How To Contribute: https://openedx.org/r/how-to-contribute + +This project is currently accepting all types of contributions, bug fixes, +security fixes, maintenance work, or new features. However, please make sure +to have a discussion about your new feature idea with the maintainers prior to +beginning development to maximize the chances of your change being accepted. +You can start a conversation by creating a new issue on this repo summarizing +your idea. + +Getting Help +=========== + +If you're having trouble, we have discussion forums at +https://discuss.openedx.org where you can connect with others in the community. + +Our real-time conversations are on Slack. You can request a `Slack +invitation`_, then join our `community Slack workspace`_. Because this is a +frontend repository, the best place to discuss it would be in the `#wg-frontend +channel`_. + +For anything non-trivial, the best path is to open an issue in this repository +with as many details about the issue you are facing as you can provide. + +https://github.com/openedx/frontend-component-footer/issues + +For more information about these options, see the `Getting Help`_ page. + +.. _Slack invitation: https://openedx.org/slack +.. _community Slack workspace: https://openedx.slack.com/ +.. _#wg-frontend channel: https://openedx.slack.com/archives/C04BM6YC7A6 +.. _Getting Help: https://openedx.org/community/connect + +The Open edX Code of Conduct +============================ + +All community members are expected to follow the `Open edX Code of Conduct`_. + +.. _Open edX Code of Conduct: https://openedx.org/code-of-conduct/ + +Reporting Security Issues +========================= + +Please do not report security issues in public. Please email security@openedx.org. + .. |Build Status| image:: https://api.travis-ci.com/edx/frontend-component-footer.svg?branch=master :target: https://travis-ci.com/edx/frontend-component-footer .. |Codecov| image:: https://img.shields.io/codecov/c/github/edx/frontend-component-footer From 5279e8db3df939b0eaa131f16b34115b304b1b0a Mon Sep 17 00:00:00 2001 From: mashal-m Date: Mon, 25 Sep 2023 16:56:17 +0500 Subject: [PATCH 2/3] refactor: update readMe file --- README.rst | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/README.rst b/README.rst index 1746653cb..a14591773 100644 --- a/README.rst +++ b/README.rst @@ -35,22 +35,6 @@ Requirements This component uses ``@edx/frontend-platform`` services such as i18n, analytics, configuration, and the ``AppContext`` React component, and expects that it has been loaded into a micro-frontend that has been properly initialized via ``@edx/frontend-platform``'s ``initialize`` function. `Please visit the frontend template application to see an example. `_ -Prerequisites -============= - -The `devstack`_ is currently recommended as a development environment for your -new MFE. If you start it with ``make dev.up.lms`` that should give you -everything you need as a companion to this frontend. - -Note that it is also possible to use `Tutor`_ to develop an MFE. You can refer -to the `relevant tutor-mfe documentation`_ to get started using it. - -.. _Devstack: https://github.com/openedx/devstack - -.. _Tutor: https://github.com/overhangio/tutor - -.. _relevant tutor-mfe documentation: https://github.com/overhangio/tutor-mfe#mfe-development - Environment Variables ===================== From f80f2d7f9e22b3aca110a9f6435e0566e7341dc3 Mon Sep 17 00:00:00 2001 From: mashal-m Date: Wed, 4 Oct 2023 12:03:25 +0500 Subject: [PATCH 3/3] refactor: replace npm install with npm ci --- README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.rst b/README.rst index a14591773..82b8b4656 100644 --- a/README.rst +++ b/README.rst @@ -71,7 +71,7 @@ Cloning and Startup 3. Install npm dependencies: - ``cd frontend-component-footer && npm install`` + ``cd frontend-component-footer && npm ci`` 4. Start the dev server: