From 15d5b15793e10f3672ce6a148aa85ff7f61631a8 Mon Sep 17 00:00:00 2001
From: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>
Date: Fri, 23 Aug 2024 17:02:41 +0500
Subject: [PATCH] test: Add Node 20 to CI matrix

---
 .github/workflows/ci.yml | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 0ca121ae..651184ee 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -7,21 +7,24 @@ jobs:
     if: "!(github.actor == 'github-actions[bot]') "
     name: Build
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node: [18, 20]
+    continue-on-error: ${{ matrix.node == 20 }}
+
     steps:
     - name: Checkout
       uses: actions/checkout@v2
       with:
         # pulls all commits (needed for lerna / semantic release to correctly version)
         fetch-depth: 0
-    - name: Setup Nodejs Env
-      run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
     # pulls all tags (needed for lerna / semantic release to correctly version)
     - name: Pull All Git Tags
       run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*
     - name: Setup Nodejs
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
-        node-version: ${{ env.NODE_VER }}
+        node-version: ${{ matrix.node }}
     # lerna expects to be authenticated for publishing to NPM. This step will fail CI if NPM is not
     # authenticated, even though this build does _not_ attempt to publish, as an extra check before merge
     # that Lerna is set to publish.
@@ -29,7 +32,8 @@ jobs:
       run: |
         echo "//registry.npmjs.org/:_authToken=${{ secrets.SEMANTIC_RELEASE_NPM_TOKEN }}" >> .npmrc
         npm whoami
-    - name: Install and Setup Dependencies
+    - name: Install and Setup Dep
+    endencies
       run: npm ci
     # build must come before running linting and tests for the `dist` directory to exist.
     - name: Build