Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tagging] Per-taxonomy menu on Taxonomy List Page #105

Closed
bradenmacdonald opened this issue Sep 19, 2023 · 10 comments · Fixed by openedx/frontend-app-authoring#645
Closed

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Sep 19, 2023

Follows #104 and #113 .

"As any user with access to Studio, I can download any Taxonomy as CSV, if I have permission to view that Taxonomy."

"As any user with access to Studio, I can download any Taxonomy as JSON, if I have permission to view that Taxonomy."

"As any user with access to Studio, I get an explanation of what system-defined taxonomies are."

Acceptance Criteria

  1. Display this tooltip when a user hovers over the "System level" badge of a system-defined taxonomy:
    Screenshot 2023-10-11 at 2 34 07 PM
  2. Display the "three dots" menu button for all taxonomies, including system-defined taxonomies. Clicking it should show a menu with "Export".
    Screenshot 2023-10-12 at 10 00 39 AM
  3. Clicking that will lead to this dialog:
    Screenshot 2023-10-12 at 10 01 35 AM
  4. Selecting "Export as CSV" or "Export as JSON" should trigger the corresponding export and download the taxonomy as a file, using the API from [Tagging] REST API to trigger export of a taxonomy #113
  5. Other menu items will come in later stories: "Edit Details" in [Tagging] Edit Taxonomy Details #125, "Re-import" in [Tagging] "Bare Bones" Update of Existing Taxonomy by Uploading #140, "Manage Organizations" in [Tagging] Assign taxonomy to organizations #117, and "Delete" in [Tagging] Delete a taxonomy #127.

Developer Notes

  • Screenshots above are for convenience - Figma is the most up-to-date source for mockups. The scale of UI elements seen in the screenshots above may be incorrect.
@bradenmacdonald
Copy link
Contributor Author

@ChrisChV is there a REST API to trigger the export of a taxonomy?

@ChrisChV
Copy link

@ChrisChV is there a REST API to trigger the export of a taxonomy?

@bradenmacdonald Whops! No, in the code is missing the REST API to call the import/export. I remember seeing that task/issue somewhere. I've looked for it and can't find anything

@bradenmacdonald
Copy link
Contributor Author

@ChrisChV OK, no problem. I created #113 as a prerequisite for this issue then.

@ali-hugo
Copy link

ali-hugo commented Sep 25, 2023

@bradenmacdonald

As the wireframes currently stand, only global staff can export (i.e. download) taxonomies. Do you see a use case for which we should extend this to other user types as well? Currently the 3-dot menu only displays for global staff.

(I imagine things might change once you've received feedback on #129).

@bradenmacdonald
Copy link
Contributor Author

@ali-hugo Yes, if someone is an instructor on Site A but is a global staff on Site B, they may wish to download the taxonomy they've been using on Site A and upload it to use on Site B. In general if someone can view the taxonomy there's no reason not to let them download it IMHO, because they could always tediously re-create it step by step if they wanted to anyways.

@ali-hugo
Copy link

@bradenmacdonald That makes sense to me. I have updated the design accordingly.

Please note that users with view-only permissions don't see the cog, the lock, nor the "enabled / enabled (default)" tags; they only see the menu with the option to export as CSV and JSON. I don't think it brings much value to these users to know whether the taxonomy is system-defined or not. Let me know if you disagree.

@ali-hugo
Copy link

@bradenmacdonald @ChrisChV This is all working well for me. Just wanted to flag a few small things (all of which can be fixed at a later stage):

Screenshot 2023-11-28 at 11 07 07

  • Max width of tooltips in Paragon is 300px (the tooltip in the screenshot above looks wider)
  • The text in the "system-level" badge should not be bolded

badge

  • I noticed there is no way to see whether a taxonomy is system-level or not on the taxonomy detail page. Could we add a "system-level" badge to this page, under the page title (as shown in the mockup above)?

clickable area

  • Could we extend the clickable area to include anything within the blue block in the screenshot above? Instinctively, I tried to click here in order to select the radio button

@bradenmacdonald
Copy link
Contributor Author

^ We will fix the above shortly in FAL-3537.

@ChrisChV
Copy link

ChrisChV commented Dec 1, 2023

@ali-hugo

I noticed there is no way to see whether a taxonomy is system-level or not on the taxonomy detail page. Could we add a "system-level" badge to this page, under the page title (as shown in the mockup above)?

Should this badge show the tooltip?

@ali-hugo
Copy link

ali-hugo commented Dec 4, 2023

@ChrisChV Yes, please display the tooltip here too.

xitij2000 pushed a commit to openedx/frontend-app-authoring that referenced this issue Dec 19, 2023
This change makes the following updates to the UX of the taxonomy pages:

* On the taxonomies list, display the full name of taxonomies in a tooltip if it's longer than what's displayed
* On the taxonomy detail page, please change the title of the "Value" column to "Tag name"
* On taxonomy detail page, remove the "child tags" column and put it in parentheses instead
* Update tags count color
* Several minor issues brought up here: openedx/modular-learning#105 (comment). 
* Fix issue with scroll position not being reset on navigation
lucascalvino pushed a commit to openedx/frontend-app-authoring that referenced this issue Dec 19, 2023
This change makes the following updates to the UX of the taxonomy pages:

* On the taxonomies list, display the full name of taxonomies in a tooltip if it's longer than what's displayed
* On the taxonomy detail page, please change the title of the "Value" column to "Tag name"
* On taxonomy detail page, remove the "child tags" column and put it in parentheses instead
* Update tags count color
* Several minor issues brought up here: openedx/modular-learning#105 (comment). 
* Fix issue with scroll position not being reset on navigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants