Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Course Search] Search Modal: Filters #201

Closed
bradenmacdonald opened this issue Mar 7, 2024 · 0 comments
Closed

[Course Search] Search Modal: Filters #201

bradenmacdonald opened this issue Mar 7, 2024 · 0 comments

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Mar 7, 2024

"As a course author, when searching for content, I want to be able to filter the results by content type or tag"

Figma designs

Requirements:

Implement everything shown in Figma that's in this part of the search modal:
Screenshot 2024-03-21 at 2 34 03 PM

  1. (If currently in a course) the toggle to choose "This course" or "All courses" (and apply the appropriate filter to the search so that this toggle works).
    • (If not currently in a course) the toggle only has the option for "All courses"
  2. The keyword box
  3. The "Content" filter dropdown for refining based on content type. It becomes a chip that shows which filters are applied.
  4. The "Tags" filter dropdown. It becomes a chip that shows which filters are applied.
  5. "If the user selects a content filter and a tag filter, each result must be (content type 1 OR content type 2) AND (tag 1 AND tag 2)."
  6. The "Search Tips" dropdown, though it should only say 'Enclose phrases in quotes like "solar eclipse" for an exact search.' because like Algolia, Meilisearch doesn't support boolean operators in the keywords.

Notes:

@bradenmacdonald bradenmacdonald moved this from To refine to In Progress in Modular Learning - Tagging and Libraries Mar 27, 2024
xitij2000 pushed a commit to openedx/frontend-app-authoring that referenced this issue Apr 11, 2024
Implementation of openedx/modular-learning#201

Implements a modal for searching course content with filters for searching in current or all courses, filtering by content type, content tags and text.
xitij2000 pushed a commit to openedx/frontend-app-authoring that referenced this issue Apr 24, 2024
As of #918 , the content search only allows filtering the results by one tag at a time, which is a limitation of Instantsearch.

So with this change, usage of Instantsearch + instant-meilisearch has been replaced with direct usage of Meilisearch. Not only does this simplify the code and make our MFE bundle size smaller, but it allows us much more control over how the tags filtering works, so that we can implement searching by multiple tags.

Trying to modify Instantsearch to do that was too difficult, given the complexity of its codebase.

Related ticket: openedx/modular-learning#201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant