-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tagging] Change behaviour of Tag Drawer on click outside #209
Comments
@ChrisChV What currently happens if the user clicks outside - their changes are lost? If so we need to fix this ASAP. If "nothing" happens, it's less urgent. |
@bradenmacdonald Yes that solves this: |
@ChrisChV I see. Well if it's going to be a lot of work to implement the animation we may decide to do without it for now, until we get user feedback. But we definitely don't want users losing their work if they click off of the tag drawer. |
"As a course author, I don't want to lose the edited tags if I click outside the tag drawer"
Design: Figma
Depends on #190
Acceptance Criteria
If the user clicks on the grey area outside of the tagging drawer AND there are unsaved changes (at least one added/removed tag):
a. The drawer does not close
b. The footer of the drawer animates to draw the user's attention to the actions (see Figma). Perhaps like Blink 2 at this link
Developer notes
The text was updated successfully, but these errors were encountered: