feat: removed unused permission events #314
Conversation
zacharis278
force-pushed
the
zhancock/remove-permission-event
branch
from
26b1649 to
c100e4e
Compare
| @@ -5,4 +5,4 @@ | |||
| more information about the project. | |||
| """ | |||
|
|
|||
| __version__ = "9.5.1" | |||
| __version__ = "9.5.2" | |||
There was a problem hiding this comment.
Given that we are removing events that were public, and might be used by any other developer that imported this code, this should be a breaking change with a major version bump.
Naturally the events are not in use by edx-plaform right now. Where they ever used by that repo?
There was a problem hiding this comment.
Nope, I think this would be safe to merge w/o considering a major bump since the 'permission' models this event would be based on don't even exist. I can confidently say this has never been used. That said, I don't have strong options on if this bumps a major version or not. Just figured I'd point that out if we'd like to avoid going to v10.
In hindsight, we should not have included these until we were more certain the new permission model would get merged into edx-platform.
There was a problem hiding this comment.
If this was never really releaseda anywhere and has never been used I'm good with not bumping for major.
|
I'll look into the docs failure so we can merge this soon. |
Co-authored-by: Maria Grimaldi <[email protected]>
Description: These events were added in anticipation of the roles and permissions changes. That work is now on hold and we have instead opted to publish an event based on roles as they exist in edx-platform today. See #309. As written this event might not match the future state of that work if it is picked up again. I propose these definitions be removed to avoid confusion.
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.