Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double border on select elements with slim-select enabled #248

Open
msnassar opened this issue Jan 9, 2024 · 1 comment
Open

Double border on select elements with slim-select enabled #248

msnassar opened this issue Jan 9, 2024 · 1 comment

Comments

@msnassar
Copy link

msnassar commented Jan 9, 2024

I have noticed that the double border issue that has been reported here https://citnet.tech.ec.europa.eu/CITnet/jira/browse/OEL-2255, has been fixed in oe_whitelabel here https://github.com/openeuropa/oe_whitelabel/pull/236/files instead of fixing it in BCL (openeuropa/bootstrap-component-library#515 (comment))

After applying the solution to UCPKN, I see 2 issues:

  1. We lose the border on the corners. See the screenshot
    image
    The fix we did in ucpkn:
.ss-main.multi-select.form-select {
  border: none;
}
  1. (Trivial) Since the fix is not part of the BCL, we still have to explicitly fix the issue in ucpkn_theme. This is because the ucpkn styles comes after oe_whitelabel styles. I don't know whether the other sites will encounter the same issue or not.
@raqfialho
Copy link

Hi @msnassar, thanks for opening this issue! We appreciate your help. Would you be interested in submitting a pull request with your fix? Your contribution would be valuable to all of us :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants