Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing in corporate block footer is not aligend #285

Open
msnassar opened this issue Jun 10, 2024 · 3 comments
Open

Spacing in corporate block footer is not aligend #285

msnassar opened this issue Jun 10, 2024 · 3 comments
Labels
bug Something isn't working contribution welcome Any contribution to fix this issue is welcome

Comments

@msnassar
Copy link

In the corporate block, the top spacing for the sections in the footer is not aligned with the spacing for site name.
This is due to the fact that we have mt-3 applied on the title of the sections: See https://github.com/openeuropa/oe_whitelabel/blob/1.x/templates/overrides/navigation/oe-corporate-blocks-neutral-footer.html.twig

image

@brummbar
Copy link
Contributor

Is this fixed by #289 ?

@brummbar brummbar added bug Something isn't working question Further information is requested labels Jun 28, 2024
@msnassar
Copy link
Author

Is this fixed by #289 ?

The issue has been fixed. Thanks :)

@msnassar
Copy link
Author

Sorry, I just noticed #289 doesn't fix this issue... I thought it is, but it seems we have a local patch fixing it :)
The PR for #289 is fixing the spacing for legal and institution links title.
This issue is about the title of the top footer sections...
https://github.com/openeuropa/oe_whitelabel/blob/1.x/templates/overrides/navigation/oe-corporate-blocks-neutral-footer.html.twig#L20
https://github.com/openeuropa/oe_whitelabel/blob/1.x/templates/overrides/navigation/oe-corporate-blocks-neutral-footer.html.twig#L31

@msnassar msnassar reopened this Sep 24, 2024
@drishu drishu added contribution welcome Any contribution to fix this issue is welcome and removed question Further information is requested labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contribution welcome Any contribution to fix this issue is welcome
Projects
None yet
Development

No branches or pull requests

3 participants