No link on parameter in demo.openfisca.org

[sandcha]

On http://demo.openfisca.org/legislation/basic_income, I expect to see a link leading to parameter's page on benefits.basic_income but I get simple text.
Browser: Safari 12.0

[Morendil]

Same on Chrome 69 / Mac.

Has this worked before, is it a regression ?

Looking at the code:

legislation-explorer/src/components/formula.jsx

Line 74 in 3616e73

splitAndLinkParams = (text) => {

…what I suspect is that it never did work previously for this particular way of getting at the parameters, where we are directly using a parameter value * parameters(period).benefits.basic_income, not assigning to a temporary variable. The regex only works if there is an "=" before "parameters".

This whole approach of matching with regexes in the explorer is brittle, hard to read and debug, and hard to scale to different cases. ISTM that matching the parameters in the API instead, via AST search, would be more robust. (Not trivial, admittedly.)