Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another Pydantic v2 rewrite #42

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Another Pydantic v2 rewrite #42

wants to merge 18 commits into from

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Mar 28, 2024 •
edited
Loading

Description

This is like #26 but it doesn't attempt to precisely keep the old design.

  • Use Annotated to more directly add information to type annotations
  • Add some convenience annotated types for commonly-used dimensions
  • Test that mixed models don't immediately crash out of a v1/v2 incompatibility
  • Think about if/how to coerce squishy-but-similar types, like ensuring float are cast to int as FloatQuantity currently does
  • Rename quack_into_unit

Todos

Status

  • Ready to go

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.05556% with 46 lines in your changes missing coverage. Please review.

Project coverage is 69.93%. Comparing base (afcef40) to head (bbc2416).
Report is 2 commits behind head on main.

Additional details and impacted files

@mattwthompson mattwthompson mentioned this pull request Apr 3, 2024
Open
@mattwthompson mattwthompson marked this pull request as ready for review April 5, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattwthompson @codecov-commenter