Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forest area as proportion of total land area SDG - should be estimated bases on the latest available NDP after 2020 #3203

Closed
pengchenglai opened this issue Nov 2, 2023 · 8 comments · Fixed by #3427
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@pengchenglai
Copy link
Contributor

@minotogna

Describe the bug
Forest area as proportion of total land area SDG indicator uses the linear trend even though there is a new NDP after 2020.

To Reproduce
See Australia(screenshots below)

Expected behavior
If the latest data of NDP after 2020 is available, the Forest area as proportion of total land area should be estimated based on the latest data of NDP not the 2020 data

Screenshots
image
image

@sorja
Copy link
Contributor

sorja commented Jan 23, 2024

@pengchenglai After working with this I think we must take into account several cases
Reference PR: #3427
Could you be so kind to verify I did not miss any?


  • Table SDG 15.1.1

  • We are solely discussing the years 2021, 2022, 2023 and 2024.
  • These fields are the only editable fields
  • These fields are interpolated from existing years

  • Case 1: No data
    • Show null
  • Case 2: Data only for either year 2020 or 2025
    • Show null
  • Case 3: Data for both 2020 and 2025 but not between
    • Interpolate using 2020 and 2025 years 2021...2024

  • Case 4: Data for 2020 and 2021 and 2025
    • Extrapolate using 2020 and 2021?
      Case 5: Data for 2020 and 2021
    • Extrapolate using 2020 and 2021
  • Case 6: Data for 2021...2023
    • Extrapolate 2024 using values from year 2022 and 2023
  • Case 7: Data for 2021 and 2023
    • Interpolate 2022 using 2021 and 2023
    • Extrapolate 2024 using 2021 and 2023

Let me know if you can think of any other cases and if any of the above logic should be changed.

In short:

  • If no NDPs exist for years 2021...2024 we use 2020 and 2025.
  • If either or both of the values don't exist, then return empty

Questions:

  • If single value exists exists, is it preferred to use 2020 or 2025 to interpolate / extrapolate?
  • If two value or more values exist, should we use the NDPs always to interpolate / extrapolate and ignore values in 2020 and 2025?

Thanks

@pengchenglai
Copy link
Contributor Author

pengchenglai commented Jan 24, 2024

@sorja

Thank you. In reality, this scenario usually does not occur because the data for 2025 would be repeated from the data for 2020 or any existing data reported in previous reports if NC does not have it for 2025. : If single value exists exists, is it preferred to use 2020 or 2025 to interpolate / extrapolate?

@pengchenglai
Copy link
Contributor Author

pengchenglai commented Jan 24, 2024

@sorja

We could have a quick talk later today or tomorrow to resolve this issue which might make it easy to clarify the cases if possible

@minotogna minotogna modified the milestones: 3.1.3, 3.1.4 Feb 12, 2024
@minotogna
Copy link
Member

@pengchenglai this issue is not 100% clear:
here is an example of the formula for year 2021.

extentOfForest.forestArea['2021'] ? 
                extentOfForest.forestArea['2021'] / extentOfForest.totalLandArea['2021'] * 100 : 
                (
                  (extentOfForest.forestArea['2020'] / extentOfForest.totalLandArea['2020'] * 100 > 0 && extentOfForest.forestArea['2025'] / extentOfForest.totalLandArea['2025'] * 100) > 0 ? 
                    (extentOfForest.forestArea['2020'] / extentOfForest.totalLandArea['2020'] * 100 + ((extentOfForest.forestArea['2025'] / extentOfForest.totalLandArea['2025'] * 100 - extentOfForest.forestArea['2020'] / extentOfForest.totalLandArea['2020'] * 100) / 5 * 1)) 
                    : null
                )

how should we modify this ?
thank you

@pengchenglai
Copy link
Contributor Author

@minotogna

True, the code works for 2021. However, if the data is for 2023, then we need to add one more step to check if there are any NDPs available between 2020 and 2025.

In the case of Australia, there is no NDP for 2023, but there are NDPs for 2021 and 2022. Therefore, data from 2022 and 2025 should be used for linear estimation for the Forest area as proportion of total land area.

@minotogna
Copy link
Member

@minotogna

True, the code works for 2021. However, if the data is for 2023, then we need to add one more step to check if there are any NDPs available between 2020 and 2025.

In the case of Australia, there is no NDP for 2023, but there are NDPs for 2021 and 2022. Therefore, data from 2022 and 2025 should be used for linear estimation for the Forest area as proportion of total land area.

@pengchenglai @sorja can we have a chat tomorrow morning 10am Rome time ?

@pengchenglai
Copy link
Contributor Author

If we now use the data from 2020 and 2025 to estimate the data for 2023, the value will be lower than that of 2022. However, we know it should be the same as the value for 2022, which is 17.36.

image

@pengchenglai
Copy link
Contributor Author

@minotogna

For me it is fine

@minotogna minotogna removed the on hold label Feb 28, 2024
@mergify mergify bot closed this as completed in #3427 Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants