Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: Use DataGrid #4001

Open
39 of 48 tasks
minotogna opened this issue Oct 4, 2024 · 0 comments · May be fixed by #4104
Open
39 of 48 tasks

DataTable: Use DataGrid #4001

minotogna opened this issue Oct 4, 2024 · 0 comments · May be fixed by #4104
Assignees
Labels
discussion It requires a discussion before implementation enhancement New feature or request
Milestone

Comments

@minotogna
Copy link
Member

minotogna commented Oct 4, 2024

everything starts in src/client/pages/Section/DataTable/Table/Table.tsx

  • Fix borders of editable cells with adjacent non-editable cells

  • Code cleanup

  • Remove Select indicator in Taxon cell

  • Update ButtonCopyValues component to use the DataGrid ref instead of the Table ref

  • Calculate borders based on col and row spans

  • Check that print works as before

  • Check download functionality

  • Fix column widths and add grid template columns to table

  • Fix table headers for Forest growing stock composition -> add all headers to one row instead of two

  • Update Taxon cell component and delete old dependencies -> Use Select instead of Autocomplete

  • Update Text cells -> Use InputText and TextArea

  • Update numeric cells -> Add InputNumber

  • Investigate ColType.placeholder

  • Create new Cell styles (CellHeader and Cell)

    • Special cases:
      • Cell Headers:
        • Section.scss
          • &.section__degradedForest -> .fra-table
          • &.section__sustainableDevelopment
      • Normal Cells:
        • fraTable.scss
          • fra-table__calculated-cell
        • .fra-table - > .vgtf__container
      • rtl
      • Highligh rows (.fra-row-comments__open)
      • Review comments
  • Update colSpan/rowSpan to gridColGap / gridRowGap

  • Add row headers

  • RowData: add actions (review)

  • GridRow: add RowNoticeMessage

    • Fix last row border when the last row is noticeMessage
  • Fix src/client/pages/Section/DataTable/Table/GridRow/RowData/RowData.tsx

  • Fix src/client/pages/Section/DataTable/Table/GridRow/RowData/CellHeader/CellHeader.tsx

  • Move DataGrid (in Table.tsx) as parent of all elements

  • Update data grid style

  • go through DataTable and Table sass files

  • investigate usage of 'fra-table' css class name

  • investigate usage of 'fra-table__select-container' @minotogna see Remove ColType multiselect. Refactor Multiselect->Select isMulti #4106

  • Investigate src/client/pages/Section/DataTable/Table/GridRow/RowData/Cell/Cell.scss

New task:

  • Refactor components using the HTML table and fra-table class:
    • Move all old fra-table classes
    • client/pages/DataExport/ResultsTable/ResultsTable.tsx
    • client/pages/OriginalDataPoint/components/ExtentOfForest/ExtentOfForest.tsx
    • client/pages/OriginalDataPoint/components/ForestCharacteristics/ForestCharacteristics.tsx
    • client/pages/OriginalDataPoint/components/ForestCharacteristics/ForestCharacteristicsNaturallyRegenerating.tsx
    • client/pages/OriginalDataPoint/components/ForestCharacteristics/ForestCharacteristicsPlantation.tsx
    • Delete Thousand separated components and PercentInput after refactor.
    • Investigate and remove? all fra-table prefixed css classes ?
@minotogna minotogna added this to the 3.7.0 milestone Oct 4, 2024
@minotogna minotogna added enhancement New feature or request discussion It requires a discussion before implementation labels Oct 4, 2024
@minotogna minotogna self-assigned this Nov 7, 2024
@yaguzmang yaguzmang linked a pull request Nov 11, 2024 that will close this issue
39 tasks
@minotogna minotogna linked a pull request Dec 13, 2024 that will close this issue
39 tasks
@minotogna minotogna modified the milestones: 3.8.0, 3.9.0 Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion It requires a discussion before implementation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants