-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
why keeping json split files for the colors ? #575
Comments
That's an old one so I wanted to get rid of this issue. some reasoning about this:
let me know what you think |
I don't get what you mean with:
Ok, let's say we want to keep them in different files, in the end that's not an issue, what I believe is making this process more complicated is instead of just And, yes, I remember I posted this issue mainly to the fact of having different files for the same thing, "layer", so I would say I'm positive to left all the layer related styles in the same file. |
I haven't seen these changes before, and I want to submit a comment.
I understand the advantage of having the style files organized in different folders, especially
javascript
andcss
... what is not totally clear for me are theJSON
files.I saw that we are updating some of the properties directly after calling the objects where are going to be used, to be sure they're adapted to the current theme (as here: https://github.com/12rambau/sepal_ui/blob/a6836ec2c4e25386d2167379f950a9fbe08fc4c0/sepal_ui/mapping/map_btn.py#L30).
So IMO I think that we are creating an extra step within the implementation. We have created a color Box to deal with the colors, wouldn't be useful do the same with the json files?
@12rambau
Originally posted by @dfguerrerom in #533 (review)
The text was updated successfully, but these errors were encountered: