Skip to content

Commit

Permalink
🐛 (Argocd Apps): Fix maps instead of lists, and pin argocd-apps to la…
Browse files Browse the repository at this point in the history
  • Loading branch information
p-bizouard authored and claudusd committed Oct 16, 2024
1 parent 9cdcffb commit c326f47
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 27 deletions.
3 changes: 2 additions & 1 deletion common/argocd-apps-values.yaml.tftpl
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
applicationsets:
- name: apps
# See https://github.com/argoproj/argo-helm/commit/237493a4ab1478a0c33cb1253767f65ce4ec007c
%{ if tonumber(split(".", argocd_apps_version).0) < 2 }- name: apps%{ else }apps:%{ endif }
namespace: argocd
generators:
- git:
Expand Down
3 changes: 3 additions & 0 deletions common/argocd.tf
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,13 @@ resource "helm_release" "argocd-apps" {
repository = "https://argoproj.github.io/argo-helm"
chart = "argocd-apps"

version = var.argocd_apps_version

values = [
templatefile("${path.module}/argocd-apps-values.yaml.tftpl",
{
repo_url = var.argocd_repo_url
argocd_apps_version = var.argocd_apps_version
}
)
]
Expand Down
6 changes: 6 additions & 0 deletions common/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ variable "argocd_version" {
default = "5.33.1"
}

variable "argocd_apps_version" {
type = string
description = "ArgoCD apps version"
default = "1.6.2"
}

variable "argocd_avp_version" {
type = string
description = "ArgoCD argo-vault-plugin version"
Expand Down
52 changes: 26 additions & 26 deletions standalone/.terraform.lock.hcl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c326f47

Please sign in to comment.