If a users selects a file, the default uri also gets logged

[bermud]

Example from the log.xml. key="uri" should be null, if not is hard to know which one was ultimately tested.

<values>
   <value key="level">1</value>
   <value key="uri">https://developers.google.com/kml/documentation/KML_Samples.kml</value>    
   <value key="doc"><file-entry xmlns="http://www.occamlab.com/ctl" full-path="/srv/local/teamengine-prod/TE_BASE/users/testuser/s0001/example.kmz" media-type="application/vnd.google-earth.kmz" size="134800"/></value>
</values>

[keshavnangare]

@bermud @dstenger

This issue is appearing in all the tests if we have set the default value to URI then both values (iut-uri and iut-file) are logged in to log.xml.

The teamengine is responsible to set the form result not the ets so we need to update the teamengine and set null value to URI in case of the document is uploaded.

[keshavnangare]

Proposed implementation for fix:

• Update form with common id attribute in all the ETS form for URI [id="iut_uri"] and document [id="iut_doc"].

• Need to add validation Jquery validation in teamengine at one place instead of each form. Add onClick event on submit button with the validation method: onClick="return window.parent.validation()

• Unset the iut_uri if the document was uploaded by user.

• Add validation when both values are empty and generate alert with error message.

[keshavnangare]

@dstenger @bermud

I did all the changes as mentioned in the above comment and updated the ets-kml22 form accordingly.

I have tested this implementation with the ets-gml32 and ets-wfs20 and worked fine.

Commit: 6f96e97

Can you please review?

[keshavnangare]

Merge PR opengeospatial/teamengine#355 before this.

[lgoltz]

It makes sense to validate the input and as most ets have the possibility to pass an URL or file this can be done in the teamengine code. But I don't think it is necessary to fix the ids of the form inputs. Instead the values could be passed to the method 'validate'. Furthermore the name 'validate' should be more concrete, e.g. 'validateIutInputs'.

Unset the iut_uri if the document was uploaded by user.

I think this is the most important step. But I think this should not be done in the validate function (when the user clicks start), but when the user has uploaded a file.

[keshavnangare]

@lgoltz

Without ID filed how we can identify the filed by using values whether it is iut field or another field, it could be anything for e.g. schema URL or anything. We need ID or Name filed to clear the iut filed on the basis of file upload.

[lgoltz]

@keshav-nangare Sure, the ids are required to identify the form fields. But they should not be fix and stated in the teamengine. Instead pass the value to the teamengine code or pass the id to the teamengine code and retrieve the value with getElementById( passedID ).

[keshavnangare]

@lgoltz

I have updated the validation method to validateIutInputs('iut_uri', 'iut_doc') and we are pssing the ID's to the javascript method.

Unset the iut_uri if the document was uploaded by user.

I think this is the most important step. But I think this should not be done in the validate function (when the user clicks start), but when the user has uploaded a file.

Also I have created the new method resetIutValue(iut_uri, iut_doc), it will reset the iut_uri value if user has uploded a file. The method will call onChange event of the iut_doc (input="file") event.

[lgoltz]

@keshav-nangare

We discussed this issue again and decided to remove the example from the input field.
Please move the example to the text above the input field (replace (For example: 'http://org.com/myDocument.kml' or 'file://myDocument.kml') by (For example: 'https://developers.google.com/kml/documentation/KML_Samples.kml'). The input field should be empty by default.

Furthermore, please check if both (URL and file) are available when the user starts the test run.

[keshavnangare]

@lgoltz

Updated the form validation and moved the example above the input box and removed the default URL.