Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[insteon] Add modem database backup restore console commands #17958

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

jsetton
Copy link
Contributor

@jsetton jsetton commented Dec 23, 2024

This changes adds the ability to backup and restore a modem database via console commands. A console command to initiate a modem reset was added as well.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/insteon-binding-beta-3-3-0-3-5-0/138569/47

@jsetton jsetton force-pushed the insteon-modem-db-backup-restore branch 2 times, most recently from 1afa81f to 4463879 Compare December 23, 2024 18:06
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Dec 24, 2024
@lsiepel lsiepel requested a review from a team December 24, 2024 00:17
@jsetton jsetton force-pushed the insteon-modem-db-backup-restore branch from 4463879 to a6fcb54 Compare December 26, 2024 04:58
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these console commands, Only Thing that seems to be missing is the updated documentation.
Otherwise LGTM

@jsetton
Copy link
Contributor Author

jsetton commented Dec 31, 2024

The documentation related to console commands doesn't go in details of every command available with the new binding. If the expectation is to have all of them documented, then this should probably be handled in a separate PR.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Would be nice if you can create a new PR for the documentation about the different console commands.

@lsiepel lsiepel merged commit d54a51b into openhab:main Jan 4, 2025
3 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Jan 4, 2025
@jsetton jsetton deleted the insteon-modem-db-backup-restore branch January 4, 2025 20:11
GearrelW pushed a commit to GearrelW/openhab-addons that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants