-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please contribute to the database of supported USB sticks #818
Comments
This issue has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/please-contribute-to-database-of-z-wave-zigbee-usb-sticks/152087/1 |
1cf1:0030 Dresden Elektronik ZigBee gateway [ConBee II] |
You can check what is already in the database here |
I see in your list you have 10C4:EA60 - this is a generic CP210x serial to USB interface and will therefore very likely find a load of different devices. |
@cdjackson I guess you are responding to the comment above the last line in the database code below? :) .. Many thanks.
In this context I am weighing the utility of suggesting potential addons to new users -- they can anyway choose whether to accept the suggestions -- versus the non- utility of having too many false positives. The decision is made more complex by the fact that USB device discovery code works better or worse depending on which OS the system is on, plus various other configuration aspects (see table below). In the cases where all the data can be read, we could filter the suggestions based on the product description text in addition to the vendorId and productId. However in the other cases, we could not. So in other words, false positives are more likely on some systems than others. => I welcome your thoughts on this. |
@cdjackson apropos the above => do you have direct experience of what kind of devices would report false positives for 10C4:EA60 ? If it was a memory stick then we might have larger issues, whereas if it is something fairly exotic perhaps fewer. |
Correct - you have a comment to report false positives and my point is that these IDs are the standard ones used by the CP210x chips which are simple a serial adaptor. Therefore they will likely be picked up by many different devices.
Sure - but it's a balance, right. If it starts getting it wrong too often, then it will annoy people and be of limited work. Alternatively if it doesn't detect something, same problem... On the other hand, don't most people already know if they have a zigbee or zwave (or ??) stick since they went to the store (or online) and bought one :)
This is a generic serial bridge - it's used in a lot of devices - anything from development tools to, well, anything that interfaces USB to serial. I use it a lot in different projects here - it's like the Silabs version of the FTDI chipset that used to be used in every USB serial bridge out there. I have some commercial ESP32 devices here that use the CP210x, so they would be detected - it's a reasonably common chipset. |
Yeah. My tendency would be to suggest add-ons generously. The user can then say to themselves 'hey I don't have one of those' and decline the suggestion. (I did this myself just now on M5 .. the finder discovers my printer as two candidate suggestions -- namely HP Printer and lpp printer -- and I chose to install the first suggested add-on and not the second.) |
Interesting. Do those devices have an integration binding into OH? Because if so, we should probably suggest that binding too. Or? |
No - they aren't anything to do with openhab or home automation. My point is just that these are common chips used in loads of devices so there will likely be a lot of false suggestions when using generic IDs. |
I don’t think this is the way to go. Being too generous will downplay the value of the feature. Too many false positives will lead to people not trusting the feature at all. |
I run a A older device, but works like a charm for me. Hope that helps! |
@mherwege understood. And just so you know, the current PR is leaning towards excluding generic chips. |
@mherwege just to clarify..
|
See openhab/org.openhab.binding.zwave#1906 (comment) I have the HUSBZB-1 which is a combo Zwave/Zigbee dongle.
|
@m4rcu5 just for the avoidance of doubt, does your stick actually have the word 'ZigBee' in its name? Otherwise we would need to also check for the word 'Bitronvideo'.. |
I have probably 3 different common brands of sticks here, I missed what you want done to actually fetch the data? |
lsusb or dmesg |
I'll close this as I think it's done. If I spot any new sticks coming through I'll make sure they are added. |
Introduction
In OH core there is a PR #3922 which on new OH installations does the following..
This issue relates to point 2. above.
Background
OH has several USB device scanners for different operating systems and configurations. These scanners can ALWAYS detect the USB stick
vendorId
andproductId
integer codes. Some (but not all) of these scanners can also retrieve themanufacturer
andproduct
description strings. But unfortunately, depending on the user's operating system and user rights, the latter strings may be missing.Ideally in order to detect if a USB device supports Zigbee we would search for common strings like "Zigbee" in the
product
string. Yet on systems where the 'product' string is missing we need another way to identify what the USB device supports.In order to do this, I have started to create a database between hex 'vendorId:productId' pairs and the descriptions of known supported USB sticks. Example below..
Call to Action
Can you all please give me your contributions towards the above-mentioned database? Can you please provide me with the
vendorId
,productId
, plus a brief description similar to the examples above? Many thanks for your contributions.Signed-off-by: Andrew Fiddian-Green [email protected]
The text was updated successfully, but these errors were encountered: