Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVFPU RTL updates for implementation tools #1001

Open
pascalgouedo opened this issue Jun 12, 2024 · 2 comments
Open

CVFPU RTL updates for implementation tools #1001

pascalgouedo opened this issue Jun 12, 2024 · 2 comments
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory) PARAM:FPU Issue depends on the FPU parameter Type:Enhancement For feature requests and enhancements

Comments

@pascalgouedo
Copy link

pascalgouedo commented Jun 12, 2024

Hi @MikeOpenHWGroup & @davideschiavone

A new CVFPU PR related to implementation tools has been opened.
Even if Synopsys Design Compiler didn't complain up to now, it seems Synopsys Fusion Compiler doesn't like those few SystemVerilog RTL lines.
As this is quite an important point to be implementation tools friendly and this PR is updating 4 of CVFPU files, do we need to import those modifications in CV32E40P before v2 RTL Freeze?
If yes, we have 2 solutions:

  • create a new CVFPU release including all the updates since v0.8.1 made in August 30, 2023 and vendorize it in CV32E40P repo or
  • keep v0.8.1 and create a patch to include this PR modifications.

In both solutions we can make LEC with or without those modifications and create a new RTL tag if LEC is fine for all 7 configurations.
On verification side this new CV32E40P tag could be used on simulation non-regressions but couldn't be used for RISC-V ISA Formal Verification as it would mean killing 19 days jobs (still running!) and launch them again.

Thank you to give your thought about that.

Pascal.

PS: By the way we already did that kind of updates for Siemens EDA Tessent which didn't like some decoder RTL lines.

@pascalgouedo pascalgouedo added Type:Enhancement For feature requests and enhancements Component:RTL For issues in the RTL (e.g. for files in the rtl directory) PARAM:FPU Issue depends on the FPU parameter labels Jun 12, 2024
@davideschiavone
Copy link
Contributor

hi @pascalgouedo - the ideal solution would be revendorize cvfpu - not sure about the point you made about Formal Verification though - I agree it is not nice to kill 19 days.. but then that means we are an older RTL - However, if the new CVFPU is LEC with the old one, then it does not matter to me

@pascalgouedo
Copy link
Author

Thank you for your feedback @davideschiavone .

Finally none of these 2 solutions will be possible before RTL Freeze because it would impact RTL Code Coverage reports, waiver files and even maybe requests a new code coverage gathering from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory) PARAM:FPU Issue depends on the FPU parameter Type:Enhancement For feature requests and enhancements
Projects
None yet
Development

No branches or pull requests

2 participants