-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using credential_configuration_id in the credential request when scopes are used in the authorization request #132
Comments
I would feel more comfortable with the AS issuing the credential identifiers that can be used with the credential issuer. However since that is impossible for MSFT (and perhaps other existing OAuth deployments), adding the credential configuration id to the credential request is the second best option (even though it means to add a third option to specify the credential the wallet wants to obtain). So I'm supporting this proposal. |
I think this is generally a good change to make given the limitations of existing OAuth servers, I do wonder if we actually need to add this as a 3rd option or could remove (or at least discourage the user of) the option where
Strongly agree with this. |
I also think that it makes sense to replace the combination of Whether the Credential request should contain one of (mutually exclusive) Yet the problem for me is not the credential request. Rather it has to do with the way the wallet becomes aware of these Currently, I find this very restrictive. For starters, in pre-authorized code flow, it is not clear whether the token response can use |
There is rough consensus that it is a good idea to use credential_configuration_id in the credential request (tho credential_identifiers from the token andpoint are probably preferred...) { |
I'm in favour of adding a new
I would also be in favour of combining it with the In my head the id connects all the different endpoints and object types, which I now sometimes miss / are only available for specific flows. It would be nice if there is one
|
Currently (draft13) VCI uses in a consistent manner two different terms:
The first is present in issuer's meta-data, credential offer, I feel that the only thing missing is to allow In case that token response doesn't indicate {
"credential_configuration_id": "org.iso.18013.5.1.mDL",
"proof": {
"proof_type": "cwt",
"cwt": "..."
}
} Whereas in case token endpoint returned one or more {
"credential_configuration_id": "dimploma",
"credential_identifier": "foobar"
"proof": {
"proof_type": "jwt",
"jwt": "..."
}
} I think the above would keep clear and consistent the distinction between |
Thanks for the input. I read the part on credential_identifiers again. I mistakenly thought the values for |
If I understood this discussion correctly then I think this issue overlaps a lot with #342 |
Currently, Credential Request has two options to specify which credential is being requested:
credential_identifier
or combination offormat
and credential format specificcredential_definition
.We (Microsoft) are currently implementing VCI and we use
scopes
and cannot returncredential_identifier
from the token endpoint (because of the limitations of a big AS we are using), but we found that the performance (especially for the wallet) is better when identifier in thecredential_configurations_supported
issuer metadata is used in the credential request instead of format/type combination: it saves from comparing the combination of format and type (that is mapped to an identifier anyway) and helps prevent errors. (I think this is also what @pmhsfelix suggested at IIW)The flow would look like:
credential_configurations_supported
issuer metadataThe parameter name should probably be
credential_configuration_id
which is what is used in RAR. I don't thinkcredential_identifier
should be reused because that one has a distinct meaning and purpose.Credential Request will look pretty simple:
(mandating to return
credential_identifier
from the token response is not an option because some ASs cannot make breaking changes and cannot returncredential_identifiers
in the Token Endpoint.)The text was updated successfully, but these errors were encountered: