Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incomplete parameter definition in Credential Format Profiles #370

Open
tlodderstedt opened this issue Jul 27, 2024 · 1 comment
Open

incomplete parameter definition in Credential Format Profiles #370

tlodderstedt opened this issue Jul 27, 2024 · 1 comment

Comments

@tlodderstedt
Copy link
Collaborator

A.2.4 states "doctype: REQUIRED when the format parameter is present in the Credential Request." This text is incomplete as the expected format parameter value of "mso_mdoc" is missing.

Suggest to extend like this:

"doctype: REQUIRED when the format parameter with a value of "mso_mdoc" is present in the Credential Request."

Same holds true for A.1.1.4. and A.3.4.

@jogu
Copy link
Contributor

jogu commented Jul 27, 2024

mso_mdoc is the only allowed value for the format parameter in section A.2, so technically 'when the format parameter is present' is correct.

Would it be less confusing if written 'REQUIRED when the credential_identifier parameter is not present in the Credential Request'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants